Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests to check webdav requests with locktoken in header #34352

Merged
merged 1 commit into from
Feb 1, 2019

Conversation

individual-it
Copy link
Member

@individual-it individual-it commented Feb 1, 2019

Description

locked resources can be used by the owner when the locktoken is send in the header, test if that works correctly

Related Issue

How Has This Been Tested?

🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov
Copy link

codecov bot commented Feb 1, 2019

Codecov Report

Merging #34352 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34352   +/-   ##
=========================================
  Coverage     64.76%   64.76%           
  Complexity    18368    18368           
=========================================
  Files          1199     1199           
  Lines         69551    69551           
  Branches       1281     1281           
=========================================
  Hits          45046    45046           
  Misses        24132    24132           
  Partials        373      373
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.11% <ø> (ø) 18368 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f82ad1...8f4090b. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 1, 2019

Codecov Report

Merging #34352 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #34352      +/-   ##
============================================
- Coverage     64.76%   64.76%   -0.01%     
  Complexity    18368    18368              
============================================
  Files          1199     1199              
  Lines         69551    69550       -1     
  Branches       1281     1281              
============================================
- Hits          45046    45044       -2     
- Misses        24132    24133       +1     
  Partials        373      373
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.11% <ø> (-0.01%) 18368 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
apps/files_trashbin/lib/Expiration.php 96.55% <0%> (-1.73%) 29% <0%> (ø)
...eratedfilesharing/lib/Controller/OcmController.php 66.06% <0%> (-0.21%) 30% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f82ad1...3b550d8. Read the comment docs.

@individual-it individual-it force-pushed the testLocksWhenSendingTokenInRequest branch from 8f4090b to 3b550d8 Compare February 1, 2019 06:21
@individual-it
Copy link
Member Author

backport in #34354

@PVince81 PVince81 merged commit 6bdda88 into master Feb 1, 2019
@delete-merged-branch delete-merged-branch bot deleted the testLocksWhenSendingTokenInRequest branch February 1, 2019 08:11
@lock lock bot locked as resolved and limited conversation to collaborators Feb 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

api acceptance tests for webdav locking that send the token in the request
3 participants