Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] bump remaining symfony 3.4.22 components #34412

Merged
merged 8 commits into from
Feb 8, 2019

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Feb 8, 2019

Description

It would be nice to be able to just type composer update and let it all happen. But we are waiting for a decision on the phpseclib bump in PR #34285

There are also parts of behat-gherkin that are waiting to come out of stable10 composer. So first I did composer update and saw what symfony components it wants to touch. So I did told it to update each of those symfony components:

composer update symfony/yaml
  - Updating symfony/yaml (v3.4.21 => v3.4.22): Loading from cache
composer update symfony/stopwatch
  - Updating symfony/stopwatch (v3.4.21 => v3.4.22): Downloading (100%)
composer update symfony/options-resolver
  - Updating symfony/options-resolver (v3.4.21 => v3.4.22): Downloading (100%)
composer update symfony/finder
  - Updating symfony/finder (v3.4.21 => v3.4.22): Downloading (100%)
composer update symfony/filesystem
  - Updating symfony/filesystem (v3.4.21 => v3.4.22): Loading from cache
composer update symfony/dependency-injection
  - Removing symfony/dependency-injection (v3.4.21)
composer update symfony/config
  - Removing symfony/config (v3.4.21)
composer update symfony/class-loader
  - Removing symfony/class-loader (v3.4.21)

Then I can move on to sorting out other dependency changes that are waiting.

Motivation and Context

Sort out what symfony components composer thinks are still needed and should be at 3.4.22

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #34412 into stable10 will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34412      +/-   ##
==============================================
- Coverage        63.5%    63.5%   -0.01%     
  Complexity      19140    19140              
==============================================
  Files            1265     1265              
  Lines           75286    75285       -1     
  Branches         1291     1291              
==============================================
- Hits            47813    47810       -3     
- Misses          27093    27095       +2     
  Partials          380      380
Flag Coverage Δ Complexity Δ
#javascript 53.32% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.59% <ø> (-0.01%) 19140 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
apps/encryption/lib/Session.php 98.03% <0%> (-1.97%) 22% <0%> (ø)
apps/files_trashbin/lib/Expiration.php 96.55% <0%> (-1.73%) 29% <0%> (ø)
...eratedfilesharing/lib/Controller/OcmController.php 66.06% <0%> (-0.21%) 30% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 345da18...726e935. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #34412 into stable10 will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34412      +/-   ##
==============================================
- Coverage        63.5%    63.5%   -0.01%     
  Complexity      19140    19140              
==============================================
  Files            1265     1265              
  Lines           75286    75285       -1     
  Branches         1291     1291              
==============================================
- Hits            47813    47810       -3     
- Misses          27093    27095       +2     
  Partials          380      380
Flag Coverage Δ Complexity Δ
#javascript 53.32% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.59% <ø> (-0.01%) 19140 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
apps/encryption/lib/Session.php 98.03% <0%> (-1.97%) 22% <0%> (ø)
apps/files_trashbin/lib/Expiration.php 96.55% <0%> (-1.73%) 29% <0%> (ø)
...eratedfilesharing/lib/Controller/OcmController.php 66.06% <0%> (-0.21%) 30% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 345da18...726e935. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #34412 into stable10 will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34412      +/-   ##
==============================================
- Coverage        63.5%    63.5%   -0.01%     
  Complexity      19140    19140              
==============================================
  Files            1265     1265              
  Lines           75286    75285       -1     
  Branches         1291     1291              
==============================================
- Hits            47813    47810       -3     
- Misses          27093    27095       +2     
  Partials          380      380
Flag Coverage Δ Complexity Δ
#javascript 53.32% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.59% <ø> (-0.01%) 19140 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
apps/encryption/lib/Session.php 98.03% <0%> (-1.97%) 22% <0%> (ø)
apps/files_trashbin/lib/Expiration.php 96.55% <0%> (-1.73%) 29% <0%> (ø)
...eratedfilesharing/lib/Controller/OcmController.php 66.06% <0%> (-0.21%) 30% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 345da18...726e935. Read the comment docs.

@phil-davis phil-davis merged commit 52d7ad1 into stable10 Feb 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the stable10-symfony-3.4.22 branch February 8, 2019 03:28
@PVince81 PVince81 added this to the QA milestone Apr 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants