[stable10] Throw exception in stream_read() if attempting to read the same node multiple times #34558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…multiple times Removed extra log information, doesn't work as expected Fix comments Add missing declaration for use Sabre\DAV\Exception\BadRequest;
10 tasks
Codecov Report
@@ Coverage Diff @@
## stable10 #34558 +/- ##
==============================================
- Coverage 63.93% 63.92% -0.01%
- Complexity 19146 19153 +7
==============================================
Files 1269 1269
Lines 75553 75566 +13
Branches 1293 1293
==============================================
+ Hits 48302 48309 +7
- Misses 26870 26876 +6
Partials 381 381
Continue to review full report at Codecov.
|
2 similar comments
Codecov Report
@@ Coverage Diff @@
## stable10 #34558 +/- ##
==============================================
- Coverage 63.93% 63.92% -0.01%
- Complexity 19146 19153 +7
==============================================
Files 1269 1269
Lines 75553 75566 +13
Branches 1293 1293
==============================================
+ Hits 48302 48309 +7
- Misses 26870 26876 +6
Partials 381 381
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## stable10 #34558 +/- ##
==============================================
- Coverage 63.93% 63.92% -0.01%
- Complexity 19146 19153 +7
==============================================
Files 1269 1269
Lines 75553 75566 +13
Branches 1293 1293
==============================================
+ Hits 48302 48309 +7
- Misses 26870 26876 +6
Partials 381 381
Continue to review full report at Codecov.
|
IljaN
approved these changes
Feb 20, 2019
delete-merged-branch
bot
deleted the
stable10-assemblystream-infinite-loop
branch
This was referenced Apr 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #34489 to stable10