test deleting remote shares #34650
Merged
test deleting remote shares #34650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-davis
reviewed
Mar 1, 2019
individual-it
force-pushed
the
testDeleteRemoteShares
branch
from
cc53a25
to
40fa892
Compare
Codecov Report
@@ Coverage Diff @@
## master #34650 +/- ##
=============================================
- Coverage 65.25% 48.39% -16.87%
=============================================
Files 1207 109 -1098
Lines 69887 10493 -59394
Branches 1280 1280
=============================================
- Hits 45608 5078 -40530
+ Misses 23907 5043 -18864
Partials 372 372
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #34650 +/- ##
=========================================
Coverage 65.25% 65.25%
Complexity 18457 18457
=========================================
Files 1207 1207
Lines 69887 69887
Branches 1280 1280
=========================================
Hits 45608 45608
Misses 23907 23907
Partials 372 372
Continue to review full report at Codecov.
|
|
fixed
On 2019-03-01 2:53 p.m., Phil Davis wrote:
***@***.**** commented on this pull request.
------------------------------------------------------------------------
In tests/acceptance/features/apiFederation/federated.feature
<#34650 (comment)>:
> + | /textfile0%20(2).txt |
+ When user "user1" gets the list of federated cloud shares using the sharing API
+ Then the response should contain 0 entries
+ When user "user1" gets the list of pending federated cloud shares using the sharing API
+ Then the response should contain 0 entries
+
+ Scenario: Remote sharee tries to delete an accepted federated share sending wrong password
+ Given user "user0" from server "REMOTE" has shared "/textfile0.txt" with user "user1" from server "LOCAL"
+ And user "user1" from server "LOCAL" has accepted the last pending share
+ When user "user1" deletes the last federated cloud share with password "invalid" using the sharing API
+ Then the OCS status code should be "997"
+ And the HTTP status code should be "401"
+ And user "user1" should see the following elements
+ | /textfile0%20(2).txt |
+ When user "user1" gets the list of federated cloud shares using the sharing API
+ And the fields of the last response should include
Then
------------------------------------------------------------------------
In tests/acceptance/features/apiFederation/federated.feature
<#34650 (comment)>:
> + And user "user1" should not see the following elements
+ | /textfile0%20(2).txt |
+ When user "user1" gets the list of federated cloud shares using the sharing API
+ Then the response should contain 0 entries
+ When user "user1" gets the list of pending federated cloud shares using the sharing API
+ Then the response should contain 0 entries
+
+ Scenario: Remote sharee tries to delete a pending federated share sending wrong password
+ Given user "user0" from server "REMOTE" has shared "/textfile0.txt" with user "user1" from server "LOCAL"
+ When user "user1" deletes the last pending federated cloud share with password "invalid" using the sharing API
+ Then the OCS status code should be "997"
+ And the HTTP status code should be "401"
+ And user "user1" should not see the following elements
+ | /textfile0%20(2).txt |
+ When user "user1" gets the list of pending federated cloud shares using the sharing API
+ And the fields of the last response should include
Then
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#34650 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACUC6SqEk1A0yib69e2e0P_9Vjse7m9Eks5vSO4JgaJpZM4bYkA_>.
--
Artur Neumann
Director/CTO
Jankari Tech Pvt Ltd
www.jankaritech.com
Phone: +977 9806639223
Skype: artur.n.
GitHub: https://github.com/individual-it
|
phil-davis
approved these changes
Mar 1, 2019
|
backport in #34651 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tests to delete received remote shares
Related Issue
part of #34566
Types of changes
Checklist:
Open tasks: