-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test ocs endpoints with CORS headers #34665
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One case of not matching Origin URI is enough. Different constellations are tested in unit tests.
THX
Codecov Report
@@ Coverage Diff @@
## master #34665 +/- ##
=========================================
Coverage 65.25% 65.25%
Complexity 18458 18458
=========================================
Files 1207 1207
Lines 69895 69895
Branches 1280 1280
=========================================
Hits 45608 45608
Misses 23915 23915
Partials 372 372
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #34665 +/- ##
=========================================
Coverage 65.25% 65.25%
Complexity 18458 18458
=========================================
Files 1207 1207
Lines 69895 69895
Branches 1280 1280
=========================================
Hits 45608 45608
Misses 23915 23915
Partials 372 372
Continue to review full report at Codecov.
|
@DeepDiver1975 @phil-davis please review again. I've created new commits to make it easier to see what changed, will squash when you approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - over to @DeepDiver1975 to review the range of scenario examples
backport in #34693 |
Description
test for correct CORS headers
Related Issue
part of #34566
Types of changes
Checklist:
Open tasks: