Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test ocs endpoints with CORS headers #34665

Merged
merged 3 commits into from
Mar 6, 2019
Merged

Conversation

individual-it
Copy link
Member

@individual-it individual-it commented Mar 4, 2019

Description

test for correct CORS headers

Related Issue

part of #34566

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

Copy link
Member

@DeepDiver1975 DeepDiver1975 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One case of not matching Origin URI is enough. Different constellations are tested in unit tests.

THX

@codecov
Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #34665 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34665   +/-   ##
=========================================
  Coverage     65.25%   65.25%           
  Complexity    18458    18458           
=========================================
  Files          1207     1207           
  Lines         69895    69895           
  Branches       1280     1280           
=========================================
  Hits          45608    45608           
  Misses        23915    23915           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.65% <ø> (ø) 18458 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03e6987...48a4416. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #34665 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34665   +/-   ##
=========================================
  Coverage     65.25%   65.25%           
  Complexity    18458    18458           
=========================================
  Files          1207     1207           
  Lines         69895    69895           
  Branches       1280     1280           
=========================================
  Hits          45608    45608           
  Misses        23915    23915           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.65% <ø> (ø) 18458 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03e6987...f380b84. Read the comment docs.

@individual-it
Copy link
Member Author

@DeepDiver1975 @phil-davis please review again. I've created new commits to make it easier to see what changed, will squash when you approve

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - over to @DeepDiver1975 to review the range of scenario examples

@individual-it
Copy link
Member Author

backport in #34693

@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants