Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] bump php dependencies #34699

Closed
wants to merge 9 commits into from

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Mar 6, 2019

Description

Bump dependency versions in composer up to what is being used in master:

  1. Bump jeremeamia/superclosure 2.1.0 to 2.4.0
composer update
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 2 installs, 1 update, 0 removals
  - Installing symfony/polyfill-util (v1.10.0): Loading from cache
  - Installing symfony/polyfill-php56 (v1.10.0): Loading from cache
  - Updating jeremeamia/superclosure (2.1.0 => 2.4.0): Loading from cache
  1. Bump nikic/php-parser (v1.4.1 => v4.2.1)
composer update
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 0 installs, 1 update, 0 removals
  - Updating nikic/php-parser (v1.4.1 => v4.2.1): Loading from cache
  1. Bump swiftmailer/swiftmailer (v5.4.12 => v6.1.3)
composer update
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 1 install, 1 update, 0 removals
  - Installing egulias/email-validator (2.1.7): Loading from cache
  - Updating swiftmailer/swiftmailer (v5.4.12 => v6.1.3): Loading from cache
  1. Backport remaining parts of PR Update php parser #31926 to support the php-parser bump

  2. Backport "Adopt to Swift Mail v6" from master PR [master] Bump swiftmailer/swiftmailer from 5.4.8 to 6.0.2 #29943

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@phil-davis phil-davis self-assigned this Mar 6, 2019
@phil-davis
Copy link
Contributor Author

Stopping for now - it is getting non-obvious.
https://drone.owncloud.com/owncloud/core/15801/120

php occ app:enable files_sharing
enabling apps
An unhandled exception has been thrown:
Error: Class 'Egulias\EmailValidator\EmailValidator' not found in /drone/src/lib/private/Mail/Mailer.php:133
Stack trace:
#0 /drone/src/lib/public/Util.php(393): OC\Mail\Mailer->validateMailAddress('lostpassword-no...')
#1 /drone/src/core/register_command.php(154): OCP\Util::getDefaultEmailAddress('lostpassword-no...')
#2 /drone/src/lib/private/Console/Application.php(91): require_once('/drone/src/core...')
#3 /drone/src/console.php(105): OC\Console\Application->loadCommands(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#4 /drone/src/occ(11): require_once('/drone/src/cons...')
#5 {main}

Clue: There are a bunch of PRs in master related to autoloader, and some lines in master composer.json that probably need backporting.

@phil-davis phil-davis force-pushed the stable10-bump-php-dependencies branch from 558558d to 0e668a9 Compare March 10, 2019 02:44
@codecov
Copy link

codecov bot commented Mar 10, 2019

Codecov Report

Merging #34699 into stable10 will decrease coverage by 20.13%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             stable10   #34699       +/-   ##
===============================================
- Coverage       65.17%   45.03%   -20.14%     
===============================================
  Files            1212      116     -1096     
  Lines           68476    11465    -57011     
  Branches            0     1291     +1291     
===============================================
- Hits            44627     5163    -39464     
+ Misses          23849     5923    -17926     
- Partials            0      379      +379
Flag Coverage Δ Complexity Δ
#javascript 53.22% <ø> (?) 0 <ø> (?)
#phpunit 30.64% <ø> (-34.53%) 0 <ø> (-19244)
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Storage/DAV.php 59.45% <0%> (-21.64%) 0% <0%> (ø)
apps/updatenotification/templates/admin.php
lib/private/Encryption/Keys/Storage.php
lib/private/App/CodeChecker/NodeVisitor.php
lib/private/RedisFactory.php
apps/dav/lib/Avatars/AvatarNode.php
...s/dav/appinfo/Migrations/Version20170202213905.php
apps/dav/lib/Upload/ChunkLocationProvider.php
apps/files/lib/AppInfo/Application.php
apps/systemtags/list.php
... and 1211 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 076d734...0e668a9. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 10, 2019

Codecov Report

Merging #34699 into stable10 will decrease coverage by 20.13%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             stable10   #34699       +/-   ##
===============================================
- Coverage       65.17%   45.03%   -20.14%     
===============================================
  Files            1212      116     -1096     
  Lines           68476    11465    -57011     
  Branches            0     1291     +1291     
===============================================
- Hits            44627     5163    -39464     
+ Misses          23849     5923    -17926     
- Partials            0      379      +379
Flag Coverage Δ Complexity Δ
#javascript 53.22% <ø> (?) 0 <ø> (?)
#phpunit 30.64% <ø> (-34.53%) 0 <ø> (-19244)
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Storage/DAV.php 59.45% <0%> (-21.64%) 0% <0%> (ø)
apps/updatenotification/templates/admin.php
lib/private/Encryption/Keys/Storage.php
lib/private/App/CodeChecker/NodeVisitor.php
lib/private/RedisFactory.php
apps/dav/lib/Avatars/AvatarNode.php
...s/dav/appinfo/Migrations/Version20170202213905.php
apps/dav/lib/Upload/ChunkLocationProvider.php
apps/files/lib/AppInfo/Application.php
apps/systemtags/list.php
... and 1211 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 076d734...0e668a9. Read the comment docs.

@phil-davis
Copy link
Contributor Author

See PR "stack #34698 #34732 #34733

@phil-davis phil-davis closed this Mar 11, 2019
@phil-davis phil-davis deleted the stable10-bump-php-dependencies branch March 11, 2019 08:39
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants