Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incompatible script for generating DB changeset #34721

Merged
merged 1 commit into from
Mar 8, 2019

Conversation

PVince81
Copy link
Contributor

@PVince81 PVince81 commented Mar 8, 2019

Description

Since the move to DB migrations, this script cannot work any more,
especially considering that there can be non-DB migrations in the mix.

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

occ command doesn't show it any more

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

Since the move to DB migrations, this script cannot work any more,
especially considering that there can be non-DB migrations in the mix.
Copy link
Contributor

@sharidas sharidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 8, 2019

Codecov Report

Merging #34721 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #34721      +/-   ##
============================================
+ Coverage     65.28%    65.3%   +0.01%     
+ Complexity    18481    18478       -3     
============================================
  Files          1210     1209       -1     
  Lines         69984    69964      -20     
  Branches       1280     1280              
============================================
  Hits          45688    45688              
+ Misses        23924    23904      -20     
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.71% <ø> (+0.02%) 18478 <ø> (-3) ⬇️
Impacted Files Coverage Δ Complexity Δ
core/register_command.php 0% <ø> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a93e321...c3bf29a. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 8, 2019

Codecov Report

Merging #34721 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #34721      +/-   ##
============================================
+ Coverage     65.28%    65.3%   +0.01%     
+ Complexity    18481    18478       -3     
============================================
  Files          1210     1209       -1     
  Lines         69984    69964      -20     
  Branches       1280     1280              
============================================
  Hits          45688    45688              
+ Misses        23924    23904      -20     
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.71% <ø> (+0.02%) 18478 <ø> (-3) ⬇️
Impacted Files Coverage Δ Complexity Δ
core/register_command.php 0% <ø> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a93e321...c3bf29a. Read the comment docs.

@PVince81 PVince81 merged commit 77a815d into master Mar 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the remove-generate-change-script branch March 8, 2019 16:57
@PVince81
Copy link
Contributor Author

PVince81 commented Mar 8, 2019

stable10: #34722

@phil-davis
Copy link
Contributor

Doc removal owncloud/docs#717

@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants