Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable10] Adding background:queue commands: status and delete #34783

Merged
merged 1 commit into from
Apr 9, 2019
Merged

[stable10] Adding background:queue commands: status and delete #34783

merged 1 commit into from
Apr 9, 2019

Conversation

phil-davis
Copy link
Contributor

Backport #31630

@phil-davis phil-davis self-assigned this Mar 18, 2019
@phil-davis phil-davis mentioned this pull request Mar 18, 2019
Merged
@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #34783 into stable10 will increase coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34783      +/-   ##
==============================================
+ Coverage        64.2%    64.2%   +<.01%     
- Complexity      19883    19895      +12     
==============================================
  Files            1278     1280       +2     
  Lines           76246    76286      +40     
  Branches         1291     1291              
==============================================
+ Hits            48950    48978      +28     
- Misses          26917    26929      +12     
  Partials          379      379
Flag Coverage Δ Complexity Δ
#javascript 53.22% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.36% <66.66%> (ø) 19895 <13> (+12) ⬆️
Impacted Files Coverage Δ Complexity Δ
core/register_command.php 0% <0%> (ø) 0 <0> (ø) ⬇️
lib/private/BackgroundJob/JobList.php 74% <0%> (-5.86%) 33 <5> (+4)
core/Command/Background/Queue/Status.php 100% <100%> (ø) 4 <4> (?)
core/Command/Background/Queue/Delete.php 100% <100%> (ø) 4 <4> (?)
lib/private/BackgroundJob/Legacy/RegularJob.php 0% <0%> (ø) 3% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99798da...56dba3e. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #34783 into stable10 will increase coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34783      +/-   ##
==============================================
+ Coverage        64.2%    64.2%   +<.01%     
- Complexity      19883    19895      +12     
==============================================
  Files            1278     1280       +2     
  Lines           76246    76286      +40     
  Branches         1291     1291              
==============================================
+ Hits            48950    48978      +28     
- Misses          26917    26929      +12     
  Partials          379      379
Flag Coverage Δ Complexity Δ
#javascript 53.22% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.36% <66.66%> (ø) 19895 <13> (+12) ⬆️
Impacted Files Coverage Δ Complexity Δ
core/register_command.php 0% <0%> (ø) 0 <0> (ø) ⬇️
lib/private/BackgroundJob/JobList.php 74% <0%> (-5.86%) 33 <5> (+4)
core/Command/Background/Queue/Status.php 100% <100%> (ø) 4 <4> (?)
core/Command/Background/Queue/Delete.php 100% <100%> (ø) 4 <4> (?)
lib/private/BackgroundJob/Legacy/RegularJob.php 0% <0%> (ø) 3% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99798da...56dba3e. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 18, 2019 •
edited
Loading

Codecov Report

Merging #34783 into stable10 will increase coverage by <.01%.
The diff coverage is 67.44%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34783      +/-   ##
==============================================
+ Coverage       64.21%   64.21%   +<.01%     
- Complexity      19908    19920      +12     
==============================================
  Files            1277     1279       +2     
  Lines           76366    76407      +41     
  Branches         1292     1292              
==============================================
+ Hits            49036    49066      +30     
- Misses          26951    26962      +11     
  Partials          379      379
Flag Coverage Δ Complexity Δ
#javascript 53.2% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.38% <67.44%> (ø) 19920 <13> (+12) ⬆️
Impacted Files Coverage Δ Complexity Δ
core/register_command.php 0% <0%> (ø) 0 <0> (ø) ⬇️
lib/private/BackgroundJob/JobList.php 74% <0%> (-5.86%) 33 <5> (+4)
core/Command/Background/Queue/Status.php 100% <100%> (ø) 4 <4> (?)
core/Command/Background/Queue/Delete.php 100% <100%> (ø) 4 <4> (?)
lib/private/BackgroundJob/Legacy/RegularJob.php 0% <0%> (ø) 3% <0%> (ø) ⬇️
apps/files_trashbin/lib/Expiration.php 98.27% <0%> (+1.72%) 29% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d445ab4...b57f68b. Read the comment docs.

@phil-davis phil-davis mentioned this pull request Mar 18, 2019
Merged
9 tasks
@mmattel mmattel mentioned this pull request Mar 18, 2019
Closed
@phil-davis
Copy link
Contributor Author

Blocked. See comment on original PR: #31630 (comment)

@phil-davis phil-davis mentioned this pull request Mar 30, 2019
Closed
10 tasks
@phil-davis phil-davis force-pushed the stable10-queue-status-and-queue-delete branch from 56dba3e to b57f68b Compare April 3, 2019 05:19
@phil-davis
Copy link
Contributor Author

@PVince81 this backport is ready for review-approve-merge now that master PR #31617 is ready

@PVince81
Copy link
Contributor

PVince81 commented Apr 9, 2019

#31617 was merged

PVince81
PVince81 approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 32f1b97 into stable10 Apr 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the stable10-queue-status-and-queue-delete branch April 9, 2019 10:41
@PVince81 PVince81 added this to the QA milestone Apr 12, 2019
This was referenced Apr 15, 2019
Closed
Closed
@skshetry skshetry mentioned this pull request May 13, 2019
Closed
@paurakhsharma paurakhsharma mentioned this pull request May 14, 2019
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@tomneedham tomneedham Awaiting requested review from tomneedham

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees

@phil-davis phil-davis

Labels
3 - To Review comp:console-occ
Projects
None yet
Milestone
10.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@phil-davis @PVince81 @DeepDiver1975