Type::JSON not supported in current Doctrine #34965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doctrine/dbal 2.5 doesn't have json, so using text instead for now
PVince81
added
3 - To Review
p2-high
phil-davis
approved these changes
Apr 4, 2019
|
Oh for the day we can drop PHP 7.0 and get all the modern dependencies. |
Codecov Report
@@ Coverage Diff @@
## master #34965 +/- ##
============================================
- Coverage 65.38% 65.38% -0.01%
Complexity 18592 18592
============================================
Files 1213 1213
Lines 70408 70408
Branches 1295 1295
============================================
- Hits 46035 46034 -1
- Misses 23999 24000 +1
Partials 374 374
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #34965 +/- ##
============================================
- Coverage 65.38% 65.38% -0.01%
Complexity 18592 18592
============================================
Files 1213 1213
Lines 70408 70408
Branches 1295 1295
============================================
- Hits 46035 46034 -1
- Misses 23999 24000 +1
Partials 374 374
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doctrine/dbal 2.5 doesn't have json, so using text instead for now to avoid migration troubles.
Had to apply this on stable10 here #34951