Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set mail_send via old share API #35136

Merged
merged 1 commit into from
May 2, 2019
Merged

Set mail_send via old share API #35136

merged 1 commit into from
May 2, 2019

Conversation

VicDeo
Copy link
Member

@VicDeo VicDeo commented May 2, 2019

Description

Partially reverts 129d5e1

Related Issue

Motivation and Context

It's possible to notify group about share multiple times

How Has This Been Tested?

In accordance with #35089

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@VicDeo VicDeo added this to the development milestone May 2, 2019
@VicDeo VicDeo self-assigned this May 2, 2019
@VicDeo VicDeo requested a review from PVince81 May 2, 2019 07:44
@VicDeo
Copy link
Member Author

VicDeo commented May 2, 2019

release-10.2.0: #35137

@VicDeo VicDeo requested a review from sharidas May 2, 2019 07:53
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 makes sense, thanks

Copy link
Contributor

@sharidas sharidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented May 2, 2019

Codecov Report

Merging #35136 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #35136      +/-   ##
============================================
+ Coverage     65.47%   65.48%   +0.01%     
+ Complexity    18636    18634       -2     
============================================
  Files          1217     1217              
  Lines         70545    70534      -11     
  Branches       1296     1296              
============================================
  Hits          46192    46192              
+ Misses        23976    23965      -11     
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.5% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.87% <0%> (+0.01%) 18634 <6> (-2) ⬇️
Impacted Files Coverage Δ Complexity Δ
...es_sharing/lib/Controller/Share20OcsController.php 87.54% <0%> (+1.7%) 201 <6> (-2) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33d49e4...cc3f78f. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 2, 2019

Codecov Report

Merging #35136 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #35136      +/-   ##
============================================
+ Coverage     65.47%   65.48%   +0.01%     
+ Complexity    18636    18634       -2     
============================================
  Files          1217     1217              
  Lines         70545    70534      -11     
  Branches       1296     1296              
============================================
  Hits          46192    46192              
+ Misses        23976    23965      -11     
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.5% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.87% <0%> (+0.01%) 18634 <6> (-2) ⬇️
Impacted Files Coverage Δ Complexity Δ
...es_sharing/lib/Controller/Share20OcsController.php 87.54% <0%> (+1.7%) 201 <6> (-2) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33d49e4...cc3f78f. Read the comment docs.

@PVince81 PVince81 merged commit 83a288a into master May 2, 2019
@delete-merged-branch delete-merged-branch bot deleted the fixup-35089 branch May 2, 2019 09:15
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notify by email on group share can be done multiple times
3 participants