-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
encode jobs that have an array as job value #35224
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
Signed-off-by: Patrick Jahns <github@patrickjahns.de>
f384467
to
c46bff8
Compare
Codecov Report
@@ Coverage Diff @@
## master #35224 +/- ##
============================================
+ Coverage 65.53% 65.54% +<.01%
- Complexity 18645 18647 +2
============================================
Files 1218 1218
Lines 70540 70544 +4
Branches 1288 1288
============================================
+ Hits 46231 46235 +4
Misses 23932 23932
Partials 377 377
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #35224 +/- ##
============================================
+ Coverage 65.53% 65.54% +<.01%
- Complexity 18645 18647 +2
============================================
Files 1218 1218
Lines 70540 70544 +4
Branches 1288 1288
============================================
+ Hits 46231 46235 +4
Misses 23932 23932
Partials 377 377
Continue to review full report at Codecov.
|
CC @paurakhsharma please adjust the tests you are writing accordingly |
Description
If the argument of a job is an array, json_encode it
Related Issue
Motivation and Context
Fix #35222
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: