-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test repair step listing commands #35257
Conversation
* | ||
* @return void | ||
*/ | ||
public function theCommandOutputTableShouldContainTheFollowingText(TableNode $table) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taken straight out of #35254
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- make sure we do not end up with two of the same functions before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@individual-it, that PR has codecov failure. Anyway, there will be merge conflicts, and need to be rebased. Better to merge this.
8b5ca61
to
1e87953
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
Codecov Report
@@ Coverage Diff @@
## master #35257 +/- ##
=========================================
Coverage 65.54% 65.54%
Complexity 18647 18647
=========================================
Files 1218 1218
Lines 70546 70546
Branches 1288 1288
=========================================
Hits 46236 46236
Misses 23933 23933
Partials 377 377
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #35257 +/- ##
============================================
- Coverage 65.54% 65.53% -0.01%
Complexity 18647 18647
============================================
Files 1218 1218
Lines 70546 70545 -1
Branches 1288 1288
============================================
- Hits 46236 46234 -2
- Misses 23933 23934 +1
Partials 377 377
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, but wait till #35254 is merged and rebase to make sure theCommandOutputTableShouldContainTheFollowingText
is not duplicated
* | ||
* @return void | ||
*/ | ||
public function theCommandOutputTableShouldContainTheFollowingText(TableNode $table) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- make sure we do not end up with two of the same functions before merging
@skshetry I do not see where a backport has happened, so I added the backport-request label. |
backport in #35280 |
Description
This adds test for
occ maintenance:repair --list
command, and an error check forocc maintenance:repair --single
(cannot be checked on happy path as it requires maintenance mode to be turned on).Related Issue
Closes #35256
Motivation and Context
How Has This Been Tested?
locally and in 🤖
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: