Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test repair step listing commands #35257

Merged
merged 1 commit into from
May 20, 2019
Merged

Test repair step listing commands #35257

merged 1 commit into from
May 20, 2019

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented May 17, 2019

Description

This adds test for occ maintenance:repair --list command, and an error check for occ maintenance:repair --single (cannot be checked on happy path as it requires maintenance mode to be turned on).

Related Issue

Closes #35256

Motivation and Context

How Has This Been Tested?

locally and in 🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

*
* @return void
*/
public function theCommandOutputTableShouldContainTheFollowingText(TableNode $table) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taken straight out of #35254

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • make sure we do not end up with two of the same functions before merging

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@individual-it, that PR has codecov failure. Anyway, there will be merge conflicts, and need to be rebased. Better to merge this.

Copy link
Member

@paurakhsharma paurakhsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

Merging #35257 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35257   +/-   ##
=========================================
  Coverage     65.54%   65.54%           
  Complexity    18647    18647           
=========================================
  Files          1218     1218           
  Lines         70546    70546           
  Branches       1288     1288           
=========================================
  Hits          46236    46236           
  Misses        23933    23933           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.9% <ø> (ø) 18647 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2873da5...1e87953. Read the comment docs.

@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

Merging #35257 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #35257      +/-   ##
============================================
- Coverage     65.54%   65.53%   -0.01%     
  Complexity    18647    18647              
============================================
  Files          1218     1218              
  Lines         70546    70545       -1     
  Branches       1288     1288              
============================================
- Hits          46236    46234       -2     
- Misses        23933    23934       +1     
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.9% <ø> (-0.01%) 18647 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
...eratedfilesharing/lib/Controller/OcmController.php 66.06% <0%> (-0.21%) 30% <0%> (ø)
lib/private/Server.php 86.57% <0%> (-0.12%) 253% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2873da5...1e87953. Read the comment docs.

Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but wait till #35254 is merged and rebase to make sure theCommandOutputTableShouldContainTheFollowingText is not duplicated

*
* @return void
*/
public function theCommandOutputTableShouldContainTheFollowingText(TableNode $table) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • make sure we do not end up with two of the same functions before merging

@skshetry skshetry merged commit c0dc3cd into master May 20, 2019
@delete-merged-branch delete-merged-branch bot deleted the test-maintenance-repair branch May 20, 2019 06:32
@phil-davis
Copy link
Contributor

@skshetry I do not see where a backport has happened, so I added the backport-request label.
Please make the backport and link to it.

@individual-it
Copy link
Member

backport in #35280

@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write acceptance test for repair step list #34499
4 participants