Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for app management for apps-external path #35621

Merged
merged 1 commit into from
Jun 24, 2019
Merged

Add tests for app management for apps-external path #35621

merged 1 commit into from
Jun 24, 2019

Conversation

skshetry
Copy link
Member

Description

Adds tests for current apps vs apps-external scenarios.

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@skshetry skshetry self-assigned this Jun 21, 2019
paurakhsharma
paurakhsharma reviewed Jun 21, 2019
View reviewed changes
Copy link
Member

@paurakhsharma paurakhsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@phil-davis
Copy link
Contributor

o codecove came. @DeepDiver1975 please merge.

@DeepDiver1975 DeepDiver1975 merged commit 1e39a91 into master Jun 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the test-apps-external branch June 24, 2019 07:23
@phil-davis phil-davis mentioned this pull request Jun 24, 2019
Merged
@phil-davis
Copy link
Contributor

Backport stable10 #35631

@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paurakhsharma paurakhsharma paurakhsharma left review comments

@phil-davis phil-davis phil-davis approved these changes

@dpakach dpakach Awaiting requested review from dpakach

@haribhandari07 haribhandari07 Awaiting requested review from haribhandari07

@individual-it individual-it Awaiting requested review from individual-it

Assignees

@skshetry skshetry

Labels
4 - To release dev:acceptance-tests QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Acceptance tests using pre-installed apps_paths
4 participants
@skshetry @phil-davis @paurakhsharma @DeepDiver1975