Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webUI tests for share only with membership groups #35736

Merged
merged 1 commit into from
Jul 3, 2019

Conversation

paurakhsharma
Copy link
Member

Description

Add webUI tests for share with only membership groups.

Related Issue

#35673

Motivation and Context

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link
Contributor

@dpakach dpakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@paurakhsharma paurakhsharma requested a review from phil-davis July 2, 2019 11:28
@paurakhsharma paurakhsharma force-pushed the webUI-test-shareOnlyWithMembershipGroups branch from 1f475bb to e515994 Compare July 2, 2019 11:28
@codecov
Copy link

codecov bot commented Jul 2, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@f60d4aa). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35736   +/-   ##
=========================================
  Coverage          ?   49.09%           
=========================================
  Files             ?      109           
  Lines             ?    10535           
  Branches          ?     1289           
=========================================
  Hits              ?     5172           
  Misses            ?     4985           
  Partials          ?      378
Flag Coverage Δ
#javascript 53.7% <ø> (?)
#phpunit 38.78% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f60d4aa...e515994. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 2, 2019

Codecov Report

Merging #35736 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35736   +/-   ##
=========================================
  Coverage     65.81%   65.81%           
  Complexity    18818    18818           
=========================================
  Files          1228     1228           
  Lines         70982    70982           
  Branches       1289     1289           
=========================================
  Hits          46716    46716           
  Misses        23888    23888           
  Partials        378      378
Flag Coverage Δ Complexity Δ
#javascript 53.7% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.19% <ø> (ø) 18818 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd8c3d7...82b2a2f. Read the comment docs.

@paurakhsharma paurakhsharma force-pushed the webUI-test-shareOnlyWithMembershipGroups branch from e515994 to e3fbf8b Compare July 3, 2019 05:47
@paurakhsharma paurakhsharma force-pushed the webUI-test-shareOnlyWithMembershipGroups branch from e3fbf8b to 82b2a2f Compare July 3, 2019 07:19
@paurakhsharma paurakhsharma merged commit bb93190 into master Jul 3, 2019
@delete-merged-branch delete-merged-branch bot deleted the webUI-test-shareOnlyWithMembershipGroups branch July 3, 2019 09:22
@paurakhsharma
Copy link
Member Author

Backport on: #35753

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants