Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable10] Kill APC and XCache - fixes #28597 #35782

Merged
merged 1 commit into from
Jul 8, 2019
Merged

[stable10] Kill APC and XCache - fixes #28597 #35782

merged 1 commit into from
Jul 8, 2019

Conversation

phil-davis
Copy link
Contributor

Description

Backport from #28043 of a596201

This commit is currently sitting waiting in #34936 [stable10] "drop PHP 7.0"
But [stable10] "Introduce phpstan" #35774 is having to specifically exclude APC.php
So it will be easier all-round if we can delete this code now.
IMO it was only waiting for PHP 5.6 to be dropped.

Related Issue

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@phil-davis phil-davis self-assigned this Jul 8, 2019
@phil-davis phil-davis mentioned this pull request Jul 8, 2019
Merged
10 tasks
@phil-davis
Copy link
Contributor Author

@DeepDiver1975 Does this seem OK to do now?

@DeepDiver1975 DeepDiver1975 merged commit 97f4a62 into stable10 Jul 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the stable10-kill-apc-xcache branch July 8, 2019 17:57
@mmattel mmattel mentioned this pull request Sep 2, 2019
Closed
@davitol davitol mentioned this pull request Sep 3, 2019
Closed
13 tasks
@VicDeo VicDeo mentioned this pull request Dec 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeepDiver1975 DeepDiver1975 DeepDiver1975 approved these changes

@micbar micbar Awaiting requested review from micbar

Assignees

@phil-davis phil-davis

Labels
3 - To Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phil-davis @DeepDiver1975 @patrickjahns