-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve wording of minimum supported comment #36796
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And do:
make test-php-style-fix
to correct the formatting (CI was failing on code style)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
words LGTM
@micbar what is the process for changelog with this sort of thing? |
https://drone.owncloud.com/owncloud/core/22811/2/6 |
Please do a change in the text.
Following background: Proposal:
|
@jnweiger ping |
40dbb8a
to
d47e88d
Compare
I fixed and squashed the stuff, cleaned up some things additionally. @phil-davis ready to review/merge |
9951a68
to
1240bda
Compare
Codecov Report
@@ Coverage Diff @@
## master #36796 +/- ##
=========================================
Coverage 64.70% 64.70%
Complexity 19130 19130
=========================================
Files 1270 1270
Lines 74868 74868
Branches 1329 1329
=========================================
Hits 48447 48447
Misses 26030 26030
Partials 391 391
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
words LGTM
@micbar what is the process for changelog with this sort of thing?
@micbar do we need a changelog for this PR? |
The description for the 'minimum.supported.desktop.version' parameter was misleading. The term 'supported' had multiple meanings here. This PR tries to make the language clearer.
Can we change the name of the parameter to 'minimum.allowed.desktop.version' too? I fear this needs migration steps and has other pitfalls.