Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/dont disclose sensitive data to the log #36961

Merged
merged 3 commits into from
Feb 18, 2020

Conversation

DeepDiver1975
Copy link
Member

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov
Copy link

codecov bot commented Feb 17, 2020

Codecov Report

Merging #36961 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #36961   +/-   ##
=========================================
  Coverage     64.75%   64.75%           
  Complexity    19137    19137           
=========================================
  Files          1270     1270           
  Lines         74909    74909           
  Branches       1329     1329           
=========================================
  Hits          48506    48506           
  Misses        26012    26012           
  Partials        391      391           
Flag Coverage Δ Complexity Δ
#javascript 54.17% <ø> (ø) 0.00 <ø> (ø) ⬆️
#phpunit 65.93% <0.00%> (ø) 19137.00 <0.00> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd3d8ff...372bd7c. Read the comment docs.

@DeepDiver1975 DeepDiver1975 requested review from C0rby and removed request for PVince81 February 18, 2020 08:49
Copy link
Contributor

@C0rby C0rby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@DeepDiver1975 DeepDiver1975 marked this pull request as ready for review February 18, 2020 10:40
@micbar micbar merged commit 1c05823 into master Feb 18, 2020
@owncloud owncloud deleted a comment from update-docs bot Feb 18, 2020
@delete-merged-branch delete-merged-branch bot deleted the bugfix/dont-disclose-sensitive-data-to-the-log branch February 18, 2020 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants