Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Graffino/Browser-Update v2.0.2 to v2.0.5 #36981

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Feb 19, 2020

Description

Bump Graffino/Browser-Update to the recently-tagged patch version.

Related Issue

Also see text in https://github.com/Graffino/browser-update/issues/1

Motivation and Context

There was a problem last night with the https://github.com/Graffino/browser-update repo getting messed-up and losing the v2.0.2 release tag. That has been corrected now, and as well as the original v2.0.2 tag, there is a new v2.0.5 tag. It would be good to update to that tag, just to know that it works.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis
Copy link
Contributor Author

IMO the security/snyk fail is because the v2.0.5 tag is so new?

@phil-davis
Copy link
Contributor Author

We want to put this in master so that all the regular CI sees this.Maybe we also want to make a PR to put it into release-10.4.0 also?

@codecov
Copy link

codecov bot commented Feb 19, 2020

Codecov Report

Merging #36981 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #36981   +/-   ##
=========================================
  Coverage     64.75%   64.75%           
  Complexity    19138    19138           
=========================================
  Files          1270     1270           
  Lines         74912    74912           
  Branches       1329     1329           
=========================================
  Hits          48507    48507           
  Misses        26014    26014           
  Partials        391      391           
Flag Coverage Δ Complexity Δ
#javascript 100.00% <ø> (+45.82%) 0.00 <ø> (ø) ⬆️
#phpunit 65.82% <ø> (-0.10%) 20032.00 <ø> (+894.00)
Impacted Files Coverage Δ Complexity Δ
core/js/mimetype.js 100.00% <0.00%> (ø) 0.00% <0.00%> (ø%) ⬆️
core/js/mimetypelist.js 100.00% <0.00%> (ø) 0.00% <0.00%> (ø%) ⬆️
apps/systemtags/js/systemtagsinfoview.js 91.83% <0.00%> (ø) 0.00% <0.00%> (ø%) ⬆️
core/js/l10n.js 90.54% <0.00%> (ø) 0.00% <0.00%> (ø%) ⬆️
apps/files_sharing/js/sharedfilelist.js 82.96% <0.00%> (ø) 0.00% <0.00%> (ø%) ⬆️
apps/files_versions/js/versionmodel.js 82.60% <0.00%> (ø) 0.00% <0.00%> (ø%) ⬆️
apps/files_versions/js/versionstabview.js 80.41% <0.00%> (ø) 0.00% <0.00%> (ø%) ⬆️
apps/comments/js/commentcollection.js 72.72% <0.00%> (ø) 0.00% <0.00%> (ø%) ⬆️
apps/files_sharing/js/share.js 72.44% <0.00%> (ø) 0.00% <0.00%> (ø%) ⬆️
apps/systemtags/js/systemtagsfilelist.js 72.34% <0.00%> (ø) 0.00% <0.00%> (ø%) ⬆️
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af2077f...159b17f. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Feb 19, 2020

Codecov Report

Merging #36981 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #36981   +/-   ##
=========================================
  Coverage     64.75%   64.75%           
  Complexity    19138    19138           
=========================================
  Files          1270     1270           
  Lines         74912    74912           
  Branches       1329     1329           
=========================================
  Hits          48507    48507           
  Misses        26014    26014           
  Partials        391      391
Flag Coverage Δ Complexity Δ
#javascript 100% <ø> (+45.82%) 0 <ø> (ø) ⬇️
#phpunit 65.82% <ø> (-0.1%) 20032 <ø> (+894)
Impacted Files Coverage Δ Complexity Δ
core/js/mimetype.js 100% <0%> (ø) 0% <0%> (ø) ⬇️
core/js/mimetypelist.js 100% <0%> (ø) 0% <0%> (ø) ⬇️
apps/systemtags/js/systemtagsinfoview.js 91.83% <0%> (ø) 0% <0%> (ø) ⬇️
core/js/l10n.js 90.54% <0%> (ø) 0% <0%> (ø) ⬇️
apps/files_sharing/js/sharedfilelist.js 82.96% <0%> (ø) 0% <0%> (ø) ⬇️
apps/files_versions/js/versionmodel.js 82.6% <0%> (ø) 0% <0%> (ø) ⬇️
apps/files_versions/js/versionstabview.js 80.41% <0%> (ø) 0% <0%> (ø) ⬇️
apps/comments/js/commentcollection.js 72.72% <0%> (ø) 0% <0%> (ø) ⬇️
apps/files_sharing/js/share.js 72.44% <0%> (ø) 0% <0%> (ø) ⬇️
apps/systemtags/js/systemtagsfilelist.js 72.34% <0%> (ø) 0% <0%> (ø) ⬇️
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af2077f...159b17f. Read the comment docs.

@phil-davis phil-davis merged commit b74cffe into master Feb 19, 2020
@delete-merged-branch delete-merged-branch bot deleted the bump-Graffino/Browser-Update-v2.0.5 branch February 19, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graffino/Browser-Update v2.0.2 not found
3 participants