Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove full-stop from reset password success message #36984

Merged
merged 1 commit into from
Feb 20, 2020

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Feb 20, 2020

Description

When doing occ user:resetpassword username --password-from-env --send-email
the message "Successfully reset password for username" had a full-stop at the
end. Without --send-email there was no full-stop. The full-stop has been
removed to make the messages consistent.

$ php occ user:resetpassword testuser --password-from-env --send-email
Successfully reset password for testuser.
$ php occ user:resetpassword testuser --password-from-env
Successfully reset password for testuser

(I noticed this while investigating some password reset scenarios that were failing with encryption)

How Has This Been Tested?

The commands now output:

$ php occ user:resetpassword testuser --password-from-env --send-email
Successfully reset password for testuser
$ php occ user:resetpassword testuser --password-from-env
Successfully reset password for testuser

Both commands now give the same output (no full-stop)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis force-pushed the remove-dot-from-reset-password-output branch from 28f990b to 12f5bf1 Compare February 20, 2020 06:36
@codecov
Copy link

codecov bot commented Feb 20, 2020

Codecov Report

Merging #36984 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #36984      +/-   ##
============================================
- Coverage     64.62%   64.49%   -0.13%     
  Complexity    19138    19138              
============================================
  Files          1270     1270              
  Lines         74912    74912              
  Branches       1329     1329              
============================================
- Hits          48411    48314      -97     
- Misses        26110    26207      +97     
  Partials        391      391              
Flag Coverage Δ Complexity Δ
#javascript 54.17% <ø> (ø) 0.00 <ø> (ø) ⬆️
#phpunit 65.46% <100.00%> (-0.33%) 19138.00 <0.00> (ø)
Impacted Files Coverage Δ Complexity Δ
lib/private/DB/AdapterOCI8.php 0.00% <0.00%> (-86.67%) 4.00% <0.00%> (ø%)
...Builder/ExpressionBuilder/OCIExpressionBuilder.php 0.00% <0.00%> (-85.19%) 18.00% <0.00%> (ø%)
lib/private/DB/OracleMigrator.php 0.00% <0.00%> (-76.85%) 10.00% <0.00%> (ø%)
lib/private/DB/OracleConnection.php 0.00% <0.00%> (-66.67%) 12.00% <0.00%> (ø%)
apps/files_external/lib/Lib/Storage/SFTP.php 57.48% <0.00%> (ø) 0.00% <0.00%> (ø%) ⬆️
lib/private/DB/Adapter.php 82.71% <0.00%> (-6.18%) 25.00% <0.00%> (ø%)
lib/private/Repair/RepairMismatchFileCachePath.php 94.55% <0.00%> (-3.12%) 51.00% <0.00%> (ø%)
lib/private/Repair/RepairInvalidShares.php 97.26% <0.00%> (-2.74%) 17.00% <0.00%> (ø%)
lib/private/AllConfig.php 94.33% <0.00%> (-1.89%) 43.00% <0.00%> (ø%)
lib/private/Files/Cache/Cache.php 95.87% <0.00%> (-1.77%) 106.00% <0.00%> (ø%)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 504628c...12f5bf1. Read the comment docs.

@phil-davis phil-davis merged commit e9056e1 into master Feb 20, 2020
@delete-merged-branch delete-merged-branch bot deleted the remove-dot-from-reset-password-output branch February 20, 2020 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants