Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update phpseclib/phpseclib (2.0.24 => 2.0.25) #37014

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Feb 25, 2020

Description

https://github.com/phpseclib/phpseclib/releases/tag/2.0.25

Fixes an issue in 2.0.24 with slow upload speeds to SFTP phpseclib/phpseclib#1455

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #37014 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37014   +/-   ##
=========================================
  Coverage     64.75%   64.75%           
  Complexity    19138    19138           
=========================================
  Files          1270     1270           
  Lines         74912    74912           
  Branches       1329     1329           
=========================================
  Hits          48507    48507           
  Misses        26014    26014           
  Partials        391      391
Flag Coverage Δ Complexity Δ
#javascript 54.17% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.92% <ø> (ø) 19138 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 926c308...93f3fcb. Read the comment docs.

@phil-davis
Copy link
Contributor Author

Stupid license/cla check has not come. I do not have my laptop with me to send a "success" call for that to the API. I will have to do that tomorrow. If anyone with prius sees this then please merge this PR.

@phil-davis phil-davis merged commit 37da69e into master Feb 25, 2020
@delete-merged-branch delete-merged-branch bot deleted the phpseclib-2.0.25 branch February 25, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants