Remove unecessary constraint on database name

[vaab]

Description

Installation of owncloud prevents database name to have dots inside.

This is not a limitation of database (Postgres and Mysql supports this).

Owncloud is adding an artificial barrier here.

#19390
#20381

Related Issue

This topic was mentioned a few time in issues, but these are locked and closed.

• Fixes dot isn't allowed in database names #19390
• Fixes "you may not use dots in the database name" - this is false #20381

Motivation and Context

I'm installing broad list of services, and none of them have ever decided to enforce their own naming constraints by preventing their installation if we don't follow them. I'm using in my example the domain name of the service as database name (as another reporter of this bug did).

How Has This Been Tested?

Installation works out of the box with dotted domain on postgres on my install... for broader tests, I don't have the time right now.

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[claassistantio]

All committers have signed the CLA.

[codecov]

Codecov Report

Merging #37020 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #37020   +/-   ##
=========================================
  Coverage     64.75%   64.75%           
+ Complexity    19138    19137    -1     
=========================================
  Files          1270     1270           
  Lines         74912    74910    -2     
  Branches       1329     1329           
=========================================
  Hits          48507    48507           
+ Misses        26014    26012    -2     
  Partials        391      391           

Flag	Coverage Δ	Complexity Δ
#javascript	54.17% <ø> (ø)	0.00 <ø> (ø)	⬆️
#phpunit	65.93% <ø> (+<0.01%)	19137.00 <ø> (-1.00)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2124cef...9976308. Read the comment docs.

[codecov]

Codecov Report

Merging #37020 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #37020   +/-   ##
=========================================
  Coverage     64.75%   64.75%           
+ Complexity    19138    19137    -1     
=========================================
  Files          1270     1270           
  Lines         74912    74910    -2     
  Branches       1329     1329           
=========================================
  Hits          48507    48507           
+ Misses        26014    26012    -2     
  Partials        391      391           

Flag	Coverage Δ	Complexity Δ
#javascript	54.17% <ø> (ø)	0.00 <ø> (ø)	⬆️
#phpunit	65.93% <ø> (+<0.01%)	19137.00 <ø> (-1.00)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2124cef...9976308. Read the comment docs.

[phil-davis]

In PR #37021 I have run acceptance tests with the various different databases and with database name own.cloud.database They all pass except for known existing issues (see that PR for comments). Having a dot in the database name makes no difference.

[phil-davis]

@micbar can you or someone review this?
IMO it seems OK.

[DeepDiver1975]

This was added loooooong tima ago when mysql had such a limitation. 👍

[phil-davis]

PR #37057 adds the changelog for this.

[vaab]

Thx for your quick reviews and move on that matter. Continue the good work.