Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empty extension of Google drive file should not cause dot to be appended to file name #37060

Merged
merged 1 commit into from
Mar 4, 2020

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Mar 3, 2020

Description

This is a squashed version of PR #37045 with the changelog edited to have a shorter description.
See that PR for the details and discussion.

Related Issue

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis self-assigned this Mar 3, 2020
@phil-davis phil-davis requested a review from micbar March 3, 2020 03:29
@phil-davis
Copy link
Contributor Author

@curiousercreative I squashed your commits and edited the changelog to make it shorter (people reading the changelog can click the links to the issue and PR to read more). The commit still shows you as the author. Thanks for the contribution.

@micbar please get the appropriate developer to review this. And I guess @davitol might have some access already to a test Google Drive where he can manually reproduce the problem and test the fix.

@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #37060 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #37060      +/-   ##
============================================
- Coverage     64.76%   64.75%   -0.01%     
  Complexity    19135    19135              
============================================
  Files          1270     1270              
  Lines         74907    74909       +2     
  Branches       1328     1328              
============================================
  Hits          48511    48511              
- Misses        26006    26008       +2     
  Partials        390      390              
Flag Coverage Δ Complexity Δ
#javascript 54.18% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.93% <0.00%> (-0.01%) 19135.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9ef906...b8fa50b. Read the comment docs.

@phil-davis
Copy link
Contributor Author

Note: minor codecov fail because this PR changes GoogleDrive-specific code that will not be covered by unit tests.

@davitol
Copy link
Contributor

davitol commented Mar 4, 2020

And I guess @davitol might have some access already to a test Google Drive where he can manually reproduce the problem and test the fix.

Reproduced and tested the fix. With the fix dangling dot disappears and it is possible to download the file.

@phil-davis phil-davis force-pushed the googledrive-empty-extension branch from 869b596 to b8fa50b Compare March 4, 2020 10:15
@phil-davis phil-davis requested a review from jvillafanez March 4, 2020 10:15
@phil-davis phil-davis merged commit 24702d4 into master Mar 4, 2020
@delete-merged-branch delete-merged-branch bot deleted the googledrive-empty-extension branch March 4, 2020 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ownCloud should not respond 40x for Google Drive files without an extension
4 participants