-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
empty extension of Google drive file should not cause dot to be appended to file name #37060
Conversation
@curiousercreative I squashed your commits and edited the changelog to make it shorter (people reading the changelog can click the links to the issue and PR to read more). The commit still shows you as the author. Thanks for the contribution. @micbar please get the appropriate developer to review this. And I guess @davitol might have some access already to a test Google Drive where he can manually reproduce the problem and test the fix. |
Codecov Report
@@ Coverage Diff @@
## master #37060 +/- ##
============================================
- Coverage 64.76% 64.75% -0.01%
Complexity 19135 19135
============================================
Files 1270 1270
Lines 74907 74909 +2
Branches 1328 1328
============================================
Hits 48511 48511
- Misses 26006 26008 +2
Partials 390 390
Continue to review full report at Codecov.
|
Note: minor codecov fail because this PR changes GoogleDrive-specific code that will not be covered by unit tests. |
Reproduced and tested the fix. With the fix dangling dot disappears and it is possible to download the file. |
869b596
to
b8fa50b
Compare
Description
This is a squashed version of PR #37045 with the changelog edited to have a shorter description.
See that PR for the details and discussion.
Related Issue
How Has This Been Tested?
Types of changes
Checklist: