Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Scenario for renaming file with dots in the path #37087

Merged
merged 2 commits into from
Mar 10, 2020

Conversation

swoichha
Copy link
Contributor

@swoichha swoichha commented Mar 6, 2020

Description

Scenario for renaming file with dots in the path

Related Issue

#34442

Motivation and Context

How Has This Been Tested?

  • locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item

@codecov
Copy link

codecov bot commented Mar 6, 2020

Codecov Report

Merging #37087 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #37087      +/-   ##
============================================
- Coverage     64.76%   64.75%   -0.01%     
- Complexity    19136    19137       +1     
============================================
  Files          1270     1270              
  Lines         74915    74917       +2     
  Branches       1328     1328              
============================================
  Hits          48516    48516              
- Misses        26009    26011       +2     
  Partials        390      390              
Flag Coverage Δ Complexity Δ
#javascript 54.18% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.93% <ø> (-0.01%) 19137.00 <ø> (+1.00) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Session/Internal.php 0.00% <0.00%> (ø) 26.00% <0.00%> (+1.00%)
lib/base.php 3.83% <0.00%> (+0.01%) 151.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3b4a34...66d04a3. Read the comment docs.

@swoichha swoichha requested a review from jasson99 March 6, 2020 09:02
@swoichha swoichha force-pushed the rename-File-With-Dots-In-Path branch 3 times, most recently from 3a837ba to ebe1ac0 Compare March 6, 2020 09:14
@swoichha swoichha force-pushed the rename-File-With-Dots-In-Path branch from ebe1ac0 to 8b569ed Compare March 6, 2020 09:14
Copy link
Contributor

@haribhandari07 haribhandari07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: @swoichha you can add this scenario here #37089 . Right now it's ok. But no need to open a separate pr for a scenario if the scenarios are related. Just don't make 100s line of changes in your pr.

@haribhandari07 haribhandari07 changed the title [Test-Only] Scenario for renaming file with dots in the path [Tests-Only] Scenario for renaming file with dots in the path Mar 6, 2020
@owncloud owncloud deleted a comment from update-docs bot Mar 6, 2020
@swoichha swoichha force-pushed the rename-File-With-Dots-In-Path branch from d7559ab to 66d04a3 Compare March 10, 2020 03:30
@phil-davis phil-davis merged commit 113b458 into owncloud:master Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants