Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Add scenario outline for scenario in which sharer unshares the federated share and receiver no longer sees the share #37099

Merged
merged 1 commit into from
Mar 10, 2020

Conversation

jasson99
Copy link
Contributor

Description

Add scenario outline for the scenario in which sharer unshares the federated share and receiver no longer sees the share

Related Issue

#34149

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

…ted share and receiver no longer sees the share
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - it just makes the scenario happen for both OCS versions.

@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

Merging #37099 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37099   +/-   ##
=========================================
  Coverage     64.75%   64.75%           
  Complexity    19137    19137           
=========================================
  Files          1270     1270           
  Lines         74917    74917           
  Branches       1328     1328           
=========================================
  Hits          48516    48516           
  Misses        26011    26011           
  Partials        390      390
Flag Coverage Δ Complexity Δ
#javascript 54.18% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.93% <ø> (ø) 19137 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2173d83...18693af. Read the comment docs.

@jasson99 jasson99 merged commit b4987bc into master Mar 10, 2020
@delete-merged-branch delete-merged-branch bot deleted the scenarioOutlineInSharerUnsharesFedShare branch March 10, 2020 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants