Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Test that changes are correctly seen at both ends when federated sharer/receiver moves the location of share #37102

Merged

Conversation

jasson99
Copy link
Contributor

Description

Add acceptance tests to assert that the changes are seen correctly at both ends when the federated sharer or receiver moves the location of the share

Related Issue

#34149

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

…he federated sharer/receiver moves the location of share
@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

Merging #37102 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37102   +/-   ##
=========================================
  Coverage     64.75%   64.75%           
  Complexity    19137    19137           
=========================================
  Files          1270     1270           
  Lines         74917    74917           
  Branches       1328     1328           
=========================================
  Hits          48516    48516           
  Misses        26011    26011           
  Partials        390      390           
Flag Coverage Δ Complexity Δ
#javascript 54.18% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.93% <ø> (ø) 19137.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4987bc...d2f2a78. Read the comment docs.

@phil-davis phil-davis merged commit 35f7a3f into master Mar 11, 2020
@delete-merged-branch delete-merged-branch bot deleted the federatedShareReceiverMovesTheLocationOfReceivedShare branch March 11, 2020 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants