Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Removed issue tag from fixed issue #37145

Closed
wants to merge 1 commit into from

Conversation

kiranparajuli589
Copy link
Contributor

Description

After #37058, few cleanup is needed
Issue tag from the scenario is removed!

@phil-davis
Copy link
Contributor

@kiranparajuli589 we are not needing to clean these up any more. Actually the tags can be left behind, because for the future they give people a pointer to the issue in GitHub which was the reason for making the scenario. That can be useful.

@individual-it - is that what we discussed?

@kiranparajuli589
Copy link
Contributor Author

kiranparajuli589 commented Mar 20, 2020

@kiranparajuli589 we are not needing to clean these up any more. Actually the tags can be left behind, because for the future they give people a pointer to the issue in GitHub which was the reason for making the scenario. That can be useful.

@individual-it - is that what we discussed?

Oh OK! I agree with the concept, that is actually nice so that we can see our past in our future!

@codecov
Copy link

codecov bot commented Mar 20, 2020

Codecov Report

Merging #37145 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37145   +/-   ##
=========================================
  Coverage     64.85%   64.85%           
  Complexity    19136    19136           
=========================================
  Files          1267     1267           
  Lines         74895    74895           
  Branches       1331     1331           
=========================================
  Hits          48575    48575           
  Misses        25928    25928           
  Partials        392      392
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.05% <ø> (ø) 19136 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1af20af...ead1c71. Read the comment docs.

@phil-davis phil-davis deleted the remove-issue-tag branch March 20, 2020 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants