Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect sharing.federation.allowHttpFallback config option #37153

Merged
merged 1 commit into from
Mar 24, 2020

Conversation

mrow4a
Copy link
Contributor

@mrow4a mrow4a commented Mar 21, 2020

This MR in general help local testing for federated sharing :

  • catches exception that allow fallback from https->http
  • add some more unit tests testing tryHttpPostToShareEndpoint

Reasons:

  • without this MR, exception is shown to the user:
    cURL error 60: SSL certificate problem: self signed certificate
  • now, better exception is shown as request gets properly handled:
    server cannot be reached
  • now, with the config sharing.federation.allowHttpFallback set, allows to create federated share.

Do we need some documentation for this config (developer docs) ?

occ config:system:set sharing.federation.allowHttpFallback --value true --type boolean

@update-docs
Copy link

update-docs bot commented Mar 21, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@mrow4a mrow4a force-pushed the bugfix/respect-http-fallback branch from d14df2d to bb08c67 Compare March 21, 2020 11:37
@codecov
Copy link

codecov bot commented Mar 21, 2020

Codecov Report

Merging #37153 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37153   +/-   ##
=========================================
  Coverage     64.85%   64.86%           
  Complexity    19136    19136           
=========================================
  Files          1267     1267           
  Lines         74895    74895           
  Branches       1331     1331           
=========================================
+ Hits          48575    48578    +3     
+ Misses        25928    25925    -3     
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 66.05% <100.00%> (+<0.01%) 19136.00 <0.00> (ø)
Impacted Files Coverage Δ Complexity Δ
apps/federatedfilesharing/lib/Notifications.php 43.67% <100.00%> (+1.89%) 45.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cacea1...bb08c67. Read the comment docs.

Copy link
Member

@VicDeo VicDeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants