-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perform chunked requests in any case on any sql platoform + php 7.1 s… #37172
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
d575af8
to
4e61673
Compare
Codecov Report
@@ Coverage Diff @@
## master #37172 +/- ##
=========================================
Coverage 64.87% 64.87%
+ Complexity 19144 19143 -1
=========================================
Files 1268 1268
Lines 74940 74940
Branches 1331 1331
=========================================
Hits 48619 48619
Misses 25929 25929
Partials 392 392
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good.
AFAIK the changelog item is parsed with a script and I'm not sure if it is ok to skip the detailed description there.
Yes is is |
4e61673
to
41f8b30
Compare
…yntax cleanup
Description
We should chunk queries in any case - not only on oracle and sqlite platforms.
Related Issue
How Has This Been Tested?
Types of changes
Checklist: