Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform chunked requests in any case on any sql platoform + php 7.1 s… #37172

Merged
merged 1 commit into from
Mar 27, 2020

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Mar 26, 2020

…yntax cleanup

Description

We should chunk queries in any case - not only on oracle and sqlite platforms.

Related Issue

How Has This Been Tested?

  • live deployed at customer

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@update-docs
Copy link

update-docs bot commented Mar 26, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@DeepDiver1975 DeepDiver1975 force-pushed the bugfix/chunk-dav-props-query branch 2 times, most recently from d575af8 to 4e61673 Compare March 27, 2020 08:42
@codecov
Copy link

codecov bot commented Mar 27, 2020

Codecov Report

Merging #37172 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37172   +/-   ##
=========================================
  Coverage     64.87%   64.87%           
+ Complexity    19144    19143    -1     
=========================================
  Files          1268     1268           
  Lines         74940    74940           
  Branches       1331     1331           
=========================================
  Hits          48619    48619           
  Misses        25929    25929           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 66.07% <100.00%> (ø) 19143.00 <6.00> (-1.00)
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/DAV/FileCustomPropertiesBackend.php 88.88% <100.00%> (-0.44%) 30.00 <6.00> (-3.00)
apps/dav/lib/Files/PreviewPlugin.php 92.15% <0.00%> (+0.66%) 18.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92d7a49...41f8b30. Read the comment docs.

changelog/unreleased/37172 Outdated Show resolved Hide resolved
Copy link
Member

@VicDeo VicDeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good.
AFAIK the changelog item is parsed with a script and I'm not sure if it is ok to skip the detailed description there.

@DeepDiver1975
Copy link
Member Author

AFAIK the changelog item is parsed with a script and I'm not sure if it is ok to skip the detailed description there.

Yes is is

@phil-davis phil-davis merged commit 83133c5 into master Mar 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the bugfix/chunk-dav-props-query branch March 27, 2020 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants