Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging of general exception to error log in federated share polling #37200

Closed
wants to merge 1 commit into from

Conversation

mrow4a
Copy link
Contributor

@mrow4a mrow4a commented Apr 1, 2020

It can happen that polling throws an exception that a bit ambigous as Skipping external share with id "id" from remote "https://test.test. Reason: "". For debugging in such cases it might be better to log such exceptions to better understand the cause.

@mrow4a mrow4a requested a review from VicDeo April 1, 2020 21:37
@mrow4a mrow4a self-assigned this Apr 1, 2020
@update-docs
Copy link

update-docs bot commented Apr 1, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@mmattel
Copy link
Contributor

mmattel commented Apr 2, 2020

Pls run: make test-php-style-fix to fix coding style error(s)

@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #37200 into master will increase coverage by 0.00%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37200   +/-   ##
=========================================
  Coverage     64.87%   64.88%           
- Complexity    19146    19147    +1     
=========================================
  Files          1269     1269           
  Lines         74947    74955    +8     
  Branches       1331     1331           
=========================================
+ Hits          48625    48632    +7     
- Misses        25930    25931    +1     
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 66.07% <90.90%> (+<0.01%) 19147.00 <1.00> (+1.00)
Impacted Files Coverage Δ Complexity Δ
...s/federatedfilesharing/lib/AppInfo/Application.php 41.30% <0.00%> (-0.31%) 8.00 <0.00> (ø)
...atedfilesharing/lib/Command/PollIncomingShares.php 98.71% <100.00%> (+0.12%) 15.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a23cea4...27d1250. Read the comment docs.

@mrow4a
Copy link
Contributor Author

mrow4a commented May 14, 2020

included in #37391

@mrow4a mrow4a closed this May 14, 2020
@mrow4a mrow4a deleted the add_log_fed_sh_poll branch May 14, 2020 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants