Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Run apiVersions test on Oracle db #37296

Merged
merged 2 commits into from
Apr 23, 2020

Conversation

jasson99
Copy link
Contributor

@jasson99 jasson99 commented Apr 23, 2020

Description

Run apiVersions test on oracle DB

Related Issue

Motivation and Context

A single test scenario of apiVersions feature file fails on oracle db. This PR makes a separate scenario demonstrating the behavior of the failing one and then makes a pipeline for running the test scenario separately in oracle database.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@jasson99 jasson99 changed the title Run apiVersions test on Oracle db [Tests-Only] Run apiVersions test on Oracle db Apr 23, 2020
@jasson99 jasson99 requested a review from phil-davis April 23, 2020 06:32
@jasson99 jasson99 self-assigned this Apr 23, 2020
@jasson99 jasson99 marked this pull request as ready for review April 23, 2020 06:49
@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #37296 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37296   +/-   ##
=========================================
  Coverage     64.52%   64.52%           
  Complexity    19165    19165           
=========================================
  Files          1266     1266           
  Lines         74934    74934           
  Branches       1331     1331           
=========================================
  Hits          48353    48353           
  Misses        26189    26189           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.68% <ø> (ø) 19165.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a60b623...438511c. Read the comment docs.

@owncloud owncloud deleted a comment from update-docs bot Apr 23, 2020
.drone.star Outdated Show resolved Hide resolved
.drone.star Show resolved Hide resolved
@phil-davis phil-davis force-pushed the apiVersionsTestsWithOracleDB branch from 107ec26 to 438511c Compare April 23, 2020 10:56
@phil-davis phil-davis self-requested a review April 23, 2020 10:58
@phil-davis
Copy link
Contributor

Let's see what CI runs now.

@phil-davis
Copy link
Contributor

phil-davis commented Apr 23, 2020

https://drone.owncloud.com/owncloud/core/24429/65/13
The special scenario ran on Oracle.

https://drone.owncloud.com/owncloud/core/24429/55/13
And ordinary scenario tests/acceptance/features/apiVersions/fileVersions.feature:133 ran in the ordinary apiVersions test suite.

Good stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants