emit events for before-after-failed link password checks

[karakayasemi]

Description

This PR adds 3 new events (before-fail-after) for link password validations.

Related Issue

• Discovered in here: Public share protect (4) brute_force_protection#123 (comment)
• Partly related https://github.com/owncloud/admin_audit/issues/229
• Continuation of share manager should emit share.link auth events to catch all accesses #37430

How Has This Been Tested?

• The problem described in here fixed with this pr: Public share protect (4) brute_force_protection#123 (comment)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Changelog item

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[mmattel]

Does this need a doc change/addon in the developer section ?
If so, pls file a issue in docs.

[karakayasemi]

@mmattel the Symfony events never documented, there is an open issue about it but it seems inactive for a long time. See owncloud/docs#311

I will update the mentioned documentation issue with these events after the merge anyway. Thank you for reminding me.

[codecov]

Codecov Report

Merging #37438 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master   #37438   +/-   ##
=========================================
  Coverage     64.68%   64.68%           
  Complexity    19331    19331           
=========================================
  Files          1277     1277           
  Lines         75506    75512    +6     
  Branches       1331     1331           
=========================================
+ Hits          48838    48844    +6     
  Misses        26276    26276           
  Partials        392      392           

Flag	Coverage Δ	Complexity Δ
#javascript	54.14% <ø> (ø)	0.00 <ø> (ø)
#phpunit	65.84% <100.00%> (+<0.01%)	19331.00 <0.00> (ø)

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Share20/Manager.php	96.19% <100.00%> (+0.03%)	273.00 <0.00> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0d1351...0dfa157. Read the comment docs.

[jvillafanez]

Just for the record (this was probably there already and changing it will take time), it seems better to use an interface and ensure that the "dispatch" method is called with the right parameters; no need to rely on an actual implementation.
As said, no need to make this adjustment this now.

[jvillafanez]

Should we include a PHPDoc to clarify when the events will be thrown? It would help with the expectations in case something changes in the future.

[phil-davis]

Looks good. @karakayasemi I guess you will adjust brute_force_protection so that it will receive and respond to these?

[karakayasemi]

Looks good. @karakayasemi I guess you will adjust brute_force_protection so that it will receive and respond to these?

Yes, I expect brute_force_protection will be aware of all share password validations now.