[Tests-Only] Simplify adminSetsServerParameterToUsingAPI

[phil-davis]

Description

Acceptance test step adminSetsServerParameterToUsingAPI() has code to switch the "current user" to admin before calling modifyAppConfig(). But modifyAppConfig() already always uses the admin username anyway (because it asks the testing app to set the parameter, and the testing app only takes requests with admin auth).

There is no need to to switch the "current user" to admin and then switch it back. Simplify the code.

How Has This Been Tested?

CI

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[codecov]

Codecov Report

Merging #37585 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #37585   +/-   ##
=========================================
  Coverage     64.70%   64.70%           
  Complexity    19353    19353           
=========================================
  Files          1281     1281           
  Lines         75611    75611           
  Branches       1333     1333           
=========================================
  Hits          48924    48924           
  Misses        26295    26295           
  Partials        392      392           

Flag	Coverage Δ	Complexity Δ
#javascript	54.03% <ø> (ø)	0.00 <ø> (ø)
#phpunit	65.88% <ø> (ø)	19353.00 <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39947cc...bb7e9ff. Read the comment docs.