[Tests-Only] enable more public link share tests for get share and edit share #37633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 2, 2020 14:27
Enable tests for ocis-reva-288 related to the accepted expiration date formats. While doing so, discovered a new issue ocis-reva-335 when renaming folders that have shares on them.
Now that the public share password value is correctly returned, we can enable ocis-reva-294
PVince81
changed the title
14 tasks
Codecov Report
@@ Coverage Diff @@
## master #37633 +/- ##
=========================================
Coverage 64.74% 64.74%
Complexity 19360 19360
=========================================
Files 1281 1281
Lines 75621 75621
Branches 1333 1333
=========================================
Hits 48958 48958
Misses 26271 26271
Partials 392 392
Continue to review full report at Codecov.
|
This was referenced Jul 2, 2020
Enabled test for issue-ocis-reva-252. Tagged issue-ocis-reva-336 due to the invalid URL. Also tagged some tests with issue-ocis-reva-11 as we cannot set any settings in OCIS yet.
PVince81
changed the title
Pointing to issue-ocis-reva-333 as it's not implemented yet.
individual-it
approved these changes
Jul 3, 2020
|
PR for proof owncloud/ocis-reva#340 |
phil-davis
changed the title
phil-davis
approved these changes
Jul 3, 2020
|
Tests passed in owncloud/ocis-reva#340, merging. will update the drone PR in a subsequent PR with updated reva |
This was referenced Jul 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable more sharing tests
Enabled tests
Issues found