Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Tag tests to implement on ocis or not #37736

Merged
merged 3 commits into from
Jul 31, 2020

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jul 27, 2020

Description

Add these tags to API acceptance test scenarios:

notToImplementOnOCIS - on features that are not intended/likely to be implemented on OCIS (e.g. "app passwords" probably will not happen in OCIS in the way that it happens in oC10, there will be some different "token" auth...) This will allow us to easily skip all the scenarios that are not applicable at all to OCIS.

toImplementOnOCIS - on features that are not yet even existing/implemented on OCIS, or are some way off, or... This will allow us to easily skip all the scenarios where we know that the feature has not come yet (e.g. comments, tags, not-yet-implemented parts of sharing...) That saves running such scenarios over-and-over in OCIS CI for now.

When features start being worked on in OCIS/reva we will remove the toImplementOnOCIS tag so that they start running in OCIS/reva CI, and developers can work on making them pass.

This PR does not break any existing CI in OCIS and reva repos. It adds the new tags, but does not remove the existing skipOnOcis tags. So the existing CI that depends on skipOnOcis still works fine. After the new tags are being used in cs3org/reva, owncloud/ocis-reva and owncloud/ocis then we can think about removing all the skipOnOcis tags.

Related Issue

owncloud/ocis-reva#282

How Has This Been Tested?

CI
cs3org/reva#1036
owncloud/ocis-reva#402
owncloud/ocis#427

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #37736 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37736   +/-   ##
=========================================
  Coverage     64.71%   64.71%           
  Complexity    19386    19386           
=========================================
  Files          1283     1283           
  Lines         75735    75735           
  Branches       1333     1333           
=========================================
  Hits          49011    49011           
  Misses        26332    26332           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.89% <ø> (ø) 19386.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24b305a...c17381b. Read the comment docs.

@phil-davis phil-davis force-pushed the tag-tests-toImplementOnOCIS-or-not branch 2 times, most recently from 054cd06 to 163494b Compare July 28, 2020 14:47
@phil-davis phil-davis force-pushed the tag-tests-toImplementOnOCIS-or-not branch from 163494b to e35c913 Compare July 29, 2020 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants