Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Remove some toImplementOnOCIS tags #37879

Merged
merged 3 commits into from
Sep 3, 2020

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Sep 3, 2020

Description

comments notifications and systemtags test scenarios are already easily identified by tags on the features/scenarios. Those tags are currently being used in OCIS CI to skip these scenarios anyway.

Remove the toImplementOnOCIS tag from the scenarios. That will allow OCIS CI to easily control when they want to start running those scenarios (e.g. when someone starts working on a comments endpoint...), rather than having to come to core and remove tags.

The medium-term objective is to reduce the number of toImplementOnOCIS tags to the absolute minimum. That reduces the future need for OCIS people to have to keep coming back to core to "switch on" test scenarios.

Note: this should have no effect on the OCIS expected-failures list, because these scenarios are already skipped in the OCIS CI and will still be skipped.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants