Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Fixup API sharing test suite names #37955

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Sep 28, 2020

Description

In PR #37938 I standardized references to sharing API test suites for sharing to the root folder and sharing to the Shares folder.
But I didn't actually rename the folders in tests/acceptance/features/apiShare*
CI passed - e.g. https://drone.owncloud.com/owncloud/core/27018/60/13

Running apiShareCreateSpecialToRoot1 tests tagged ~@skipWhenTestingRemoteSystems&&~@skipOnOcV10&&~@skipOnOcV10.6&&~@skipOnOcV10.6.0&&@api&&~@skip 
No scenarios
No steps
0m0.26s (13.93Mb)
Information: no matching scenarios were found.
runsh: Total 0 scenarios (0 passed, 0 failed)
runsh: Exit code of main run: 0

Which is a bit sad - when the folder for the suite does not even exist, it happily decides that there are no feature files, no scenarios and that's it.

Fix this - get the suite names all in sync between .drone.star behat.yml and the actual folder names.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants