Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Adjust tests to better run on PGSQL #38058

Merged
merged 7 commits into from
Oct 30, 2020

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Oct 30, 2020

Description

commits 1,2,3) take the opportunity to let the IDE auto-format the gherkin files. Gets the tables lined-up in scenarios... These are purely cosmetic changes

commit 4) fix PHP doc in TagsContext

commit 5) Make oc:fileid checks more flexible - these scenarios would fail in CI with PGSQL, see #37962 https://drone.owncloud.com/owncloud/core/27379/95/13 - the code was checking for an exactly 10-digit fileid. I made it more flexible to take any length with a-z A-Z 0-9. This should be helpful for other implementations, like different OCIS storages.

commit 6) Do not run Oracle or PostgreSQL as the federated db - installing a 2nd Oracle or PGSQL database in CI is "trouble". Use mariadb in that case. We are not trying to test the particular database on the federated server.

commit 7) Create a separate test suite apiWebdavLocksUnlock - apiWebdavLocks2 had got too many features in it and was taking >1 hour to finish.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit c1eb063 into master Oct 30, 2020
@delete-merged-branch delete-merged-branch bot deleted the adjust-fileid-checks branch October 30, 2020 13:17
@phil-davis
Copy link
Contributor Author

For the record,
apiWebdavLocks 42 min
apiWebdavLocks2 46 min
apiWebdavLocksUnlock 35 min
looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants