Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] test trashbin with multi level folders #38225

Merged
merged 1 commit into from
Dec 17, 2020
Merged

[tests-only] test trashbin with multi level folders #38225

merged 1 commit into from
Dec 17, 2020

Conversation

individual-it
Copy link
Member

Description

test in trashbin API works correctly with multi level folders and its content

Related Issue

noticed that we need more tests in owncloud/ocis#1077

Motivation and Context

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@individual-it individual-it self-assigned this Dec 17, 2020
phil-davis
phil-davis approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - you decide if you want to run CI all over again just to change a Then to And

tests/acceptance/features/apiTrashbin/trashbinFilesFolders.feature
And user "Alice" has moved file "/textfile0.txt" to "/new-folder/new-file.txt"
When user "Alice" deletes folder "/new-folder/" using the WebDAV API
Then as "Alice" the file with original path "/new-folder/new-file.txt" should exist in the trashbin
Then as "Alice" the folder with original path "/new-folder/" should exist in the trashbin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Then as "Alice" the folder with original path "/new-folder/" should exist in the trashbin
And as "Alice" the folder with original path "/new-folder/" should exist in the trashbin

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@individual-it individual-it merged commit fbd41b6 into master Dec 17, 2020
@delete-merged-branch delete-merged-branch bot deleted the trashbinTestMultiLevelFolders branch December 17, 2020 07:53
This was referenced Dec 17, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

Assignees

@individual-it individual-it

Labels
3 - To Review QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@individual-it @phil-davis