[Tests-Only]Used json file to store translated messages #38412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-davis
reviewed
Feb 16, 2021
Talank
force-pushed
the
translation-test-genaralized
branch
from
d930cbd
to
12d0eea
Compare
Talank
changed the title
individual-it
approved these changes
Feb 17, 2021
Talank
force-pushed
the
translation-test-genaralized
branch
from
12d0eea
to
aee9ad4
Compare
dpakach
reviewed
Feb 17, 2021
Comment on lines
+19
to
+27
| | dav_version | language | | ||
| | old | de-DE | | ||
| | new | de-DE | | ||
| | old | zh-CN | | ||
| | new | zh-CN | | ||
| | old | fr-FR | | ||
| | new | fr-FR | | ||
| | old | es-ES | | ||
| | new | es-ES | |
There was a problem hiding this comment.
can we just have a data table rather than senario outline, that will make tests a lot faster
There was a problem hiding this comment.
can we? 🤔 Also, I wanted to reuse the logic from the step Then the OCS status message should be "<message>". So, I am not sure if it is a great idea. What do you think @phil-davis
Talank
force-pushed
the
translation-test-genaralized
branch
from
0495378
to
84a2ba2
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
generalizing API tests related to translations.
Related Issue
part of owncloud/QA#608
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: