Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-Only]used environment variable for language setup #38432

Merged
merged 2 commits into from
Mar 5, 2021
Merged

[Tests-Only]used environment variable for language setup #38432

merged 2 commits into from
Mar 5, 2021

Conversation

Talank
Copy link
Contributor

@Talank Talank commented Feb 22, 2021 •
edited
Loading

Description

used environment variable OC_LANGUAGE for language setup. Now, requests are made with the accepted language of that environment variable. And, while comparing the status message in response, we convert English to OC_LANGUAGE using the fixture file multiLanguageErrors.json and assert accordingly.

We shall need to add more data on the fixture multiLanguageErrors.json if we want to increase the scope of multiple language API tests.

Related Issue

How Has This Been Tested?

  • 🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@Talank Talank force-pushed the translation-test-genaralized-2 branch from 91c3eb8 to fbbf33c Compare February 22, 2021 06:48
@Talank Talank self-assigned this Feb 24, 2021
kiranparajuli589
kiranparajuli589 reviewed Feb 24, 2021
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm ✌️

@Talank Talank requested a review from dpakach February 25, 2021 04:29
@sonarcloud
Copy link

sonarcloud bot commented Feb 25, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

dpakach
dpakach reviewed Feb 26, 2021
View reviewed changes
Copy link
Contributor

@dpakach dpakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

individual-it
individual-it reviewed Mar 5, 2021
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for me, but I would like to have a discussion or review from @phil-davis before merging it

@phil-davis phil-davis merged commit 6fc175a into master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@dpakach dpakach dpakach left review comments

@individual-it individual-it individual-it left review comments

@phil-davis phil-davis phil-davis approved these changes

Assignees

@Talank Talank

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Talank @phil-davis @individual-it @dpakach @kiranparajuli589