[tests-only] TUS tests for checksum #38466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swoichha
requested review from
haribhandari07,
jasson99,
Talank,
kiranparajuli589 and
dpakach
9 tasks
individual-it
requested changes
Mar 4, 2021
Comment on lines
334
to
335
| * @When user :user uploads file with checksum :checksum to the last created TUS Location with offset :offset and content :content using the TUS protocol on the WebDAV API | ||
| * @Given user :user has uploaded file with checksum :checksum to the last created TUS Location with offset :offset and content :content using the TUS protocol on the WebDAV API |
There was a problem hiding this comment.
The Given step seems not to be used, if you want to have a given step, please split it off and add at least simple checks to see if it succeeded
There was a problem hiding this comment.
individual-it
requested changes
Mar 4, 2021
| string $offset, | ||
| string $content | ||
| ) { | ||
| $this->sendsAChunkToTUSLocationWithOffsetAndData($user, $offset, $content, $checksum); |
There was a problem hiding this comment.
need a check here if the step actually succeeded
swoichha
force-pushed
the
tusTests-checksum
branch
from
c4c4f72
to
19f3e75
Compare
swoichha
force-pushed
the
tusTests-checksum
branch
from
19f3e75
to
1083510
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
individual-it
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds test for TUS checksum.
Related Issue
How Has This Been Tested?
Types of changes
Checklist: