Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Tests 10.9.1 #39639

Closed
wants to merge 19 commits into from
Closed

[tests-only] Tests 10.9.1 #39639

wants to merge 19 commits into from

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jan 4, 2022

Description

This PR has some tests that were recently added to core master, and provide some extra test coverage for things that should work in 10.9.1. It will demonstrate that the tests do pass for 10.9.1.

We don't have to merge this to release-10.9.1 but we could if we like.

Related Issue

https://github.com/owncloud/enterprise/issues/4933

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis self-assigned this Jan 4, 2022
@phil-davis
Copy link
Contributor Author

Note: #39612 has a lot of acceptance test changes that accumulated during the time that release-10.9.0 was being prepared. There might be some things there that could be cherry-picked here to demonstrate that all is good for 10.9.1. I will look at that tomorrow morning.

@phil-davis
Copy link
Contributor Author

Good - the new version author and pending share access tests pass.

@phil-davis
Copy link
Contributor Author

I cherry-picked the test commits that I could from PR #39612
Note: that has changes to group name rules (group names cannot start with white-space). The tests for that have not been cherry-picked, because the related code change is only in master, for some future release.

@phil-davis
Copy link
Contributor Author

phil-davis commented Jan 5, 2022

Good - that all passes. So there are no issues with "vanilla core 10.9.1".

@phil-davis
Copy link
Contributor Author

phil-davis commented Jan 11, 2022

Issue #39662 has now been fixed and merged into release-10.9.1

I have rebased this PR and added the "version author test scenarios for issue 39662"

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis
Copy link
Contributor Author

Everything passes against the current release-10.9.1 branch, which has the RC2 code - good

@phil-davis
Copy link
Contributor Author

works. this test code is already all in master. 10.9.1 final has happened, so closing this.

@phil-davis phil-davis closed this Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants