Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] Get personal space id from the request helper #39641

Merged
merged 1 commit into from
Jan 5, 2022
Merged

[tests-only] Get personal space id from the request helper #39641

merged 1 commit into from
Jan 5, 2022

Conversation

kiranparajuli589
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 commented Jan 5, 2022 •
edited
Loading

Description

every time we'd to send the space id and usingSpaces bool to the request fn makeDavRequest

With this PR

  • we do not have to send these params in every calling fns, but get the space id within the makeDavRequest
  • updated personal space id getter

Related

@kiranparajuli589 kiranparajuli589 self-assigned this Jan 5, 2022
@kiranparajuli589 kiranparajuli589 force-pushed the followup-spaces-connection branch 2 times, most recently from acfd32f to 42a13d5 Compare January 5, 2022 07:56
saw-jan
saw-jan reviewed Jan 5, 2022
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiWebdavPreviews-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34165/95/1

@phil-davis
Copy link
Contributor

https://drone.owncloud.com/owncloud/core/34165/95/13

Type error: Argument 9 passed to TestHelpers\WebDavHelper::makeDavRequest() must be of the type int or null, string given, called in /drone/src/tests/acceptance/features/bootstrap/WebDav.php on line 398 (Behat\Testwork\Call\Exception\FatalThrowableError)

@sonarcloud
Copy link

sonarcloud bot commented Jan 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 7cee70c into master Jan 5, 2022
@delete-merged-branch delete-merged-branch bot deleted the followup-spaces-connection branch January 5, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan left review comments

@phil-davis phil-davis phil-davis approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

Assignees

@kiranparajuli589 kiranparajuli589

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kiranparajuli589 @ownclouders @phil-davis @saw-jan