Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci][tests-only] Adding spaces webdav variant for favorites api features #39686

Merged
merged 2 commits into from
Jan 17, 2022
Merged

[full-ci][tests-only] Adding spaces webdav variant for favorites api features #39686

merged 2 commits into from
Jan 17, 2022

Conversation

amrita-shrestha
Copy link
Contributor

@amrita-shrestha amrita-shrestha commented Jan 13, 2022 •
edited
Loading

Description

This PR adds tests related to spaces WebDAV in apiFavorite folder.

Related Issue

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

@amrita-shrestha amrita-shrestha self-assigned this Jan 13, 2022
@amrita-shrestha amrita-shrestha mentioned this pull request Jan 13, 2022
Merged
5 tasks
SwikritiT
SwikritiT reviewed Jan 13, 2022
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the ocis PR adjusting the expected to fail file in How Has This Been Tested? section
Otherwise looks good to me

@amrita-shrestha amrita-shrestha mentioned this pull request Jan 14, 2022
Closed
6 tasks
@amrita-shrestha amrita-shrestha force-pushed the apiFavoritesSpacesWebDav branch 2 times, most recently from be04a65 to b6e3796 Compare January 14, 2022 15:54
@amrita-shrestha amrita-shrestha marked this pull request as ready for review January 14, 2022 18:07
kiranparajuli589
kiranparajuli589 reviewed Jan 17, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

Talank
Talank reviewed Jan 17, 2022
View reviewed changes
Copy link
Contributor

@Talank Talank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kiranparajuli589
Copy link
Contributor

kiranparajuli589 commented Jan 17, 2022 •
edited
Loading

test pr build has passed https://drone.owncloud.com/owncloud/ocis/8768

@amrita-shrestha amrita-shrestha force-pushed the apiFavoritesSpacesWebDav branch 2 times, most recently from f8bb998 to 7a63e90 Compare January 17, 2022 09:14
@individual-it
Copy link
Member

please bump the commit id in ocis to make sure that gets in ASAP

@individual-it
Copy link
Member

unit tests failed with

+ wait-for-it -t 600 fsweb.test.owncloud.com:445
services aren't ready in 10m0s

restarted

@kiranparajuli589
Copy link
Contributor

php unit suites failed with

  • wait-for-it -t 600 fsweb.test.owncloud.com:445
    services aren't ready in 10m0s

build restarted!

@sonarcloud
Copy link

sonarcloud bot commented Jan 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 7c1d3d3 into master Jan 17, 2022
@delete-merged-branch delete-merged-branch bot deleted the apiFavoritesSpacesWebDav branch January 17, 2022 17:03
@amrita-shrestha amrita-shrestha mentioned this pull request Jan 18, 2022
Merged
@phil-davis phil-davis mentioned this pull request Jan 18, 2022
Closed
This was referenced Jan 18, 2022
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwikritiT SwikritiT SwikritiT left review comments

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@Talank Talank Talank left review comments

@individual-it individual-it individual-it approved these changes

@phil-davis phil-davis phil-davis approved these changes

@saw-jan saw-jan Awaiting requested review from saw-jan

Assignees

@amrita-shrestha amrita-shrestha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@amrita-shrestha @kiranparajuli589 @individual-it @phil-davis @Talank @SwikritiT