[full-ci] Acceptance tests for deep moves and fix 39702

[phil-davis]

Description

1. add test scenarios for combinations of moving a file between folders where the folder and/or file names are numeric
2. Update sabre/dav (4.3.0 to 4.3.1), which fixes the issue
3. Add test scenarios for moving file from subfolder to root

Related Issue

fixes #39702

How Has This Been Tested?

CI

In the first commit: https://drone.owncloud.com/owncloud/core/34371/93/13

runsh: Total unexpected failed scenarios throughout the test run:
apiWebdavMove2/moveFile.feature:421

In the 3rd commit, locally without tghe fix, I get:

  Background:                                                                            # /home/phil/git/owncloud/core/tests/acceptance/features/apiWebdavMove2/moveFile.feature:7
    Given using OCS API version "1"                                                      # FeatureContext::usingOcsApiVersion()
    And user "Alice" has been created with default attributes and without skeleton files # FeatureContext::userHasBeenCreatedWithDefaultAttributesAndWithoutSkeletonFiles()

  Scenario Outline: Moving a file from a folder to the root                                                         # /home/phil/git/owncloud/core/tests/acceptance/features/apiWebdavMove2/moveFile.feature:437
    Given using <dav_version> DAV path                                                                              # FeatureContext::usingOldOrNewDavPath()
    And user "Alice" has created folder "<source_folder>"                                                           # FeatureContext::userHasCreatedFolder()
    And user "Alice" has uploaded file with content "ownCloud test text file 0" to "/<source_folder>/<source_file>" # FeatureContext::userHasUploadedAFileWithContentTo()
    When user "Alice" moves file "/<source_folder>/<source_file>" to "/<target_file>" using the WebDAV API          # FeatureContext::userMovesFileUsingTheAPI()
    Then the HTTP status code should be "201"                                                                       # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    And the following headers should match these regular expressions for user "Alice"                               # FeatureContext::headersShouldMatchRegularExpressionsForUser()
      | ETag | /^"[a-f0-9:\.]{1,32}"$/ |
    And the content of file "/<target_file>" for user "Alice" should be "ownCloud test text file 0"                 # FeatureContext::contentOfFileForUserShouldBe()

    Examples:
      | dav_version | source_folder | source_file | target_file |
      | old         | 0             | file.txt    | file.txt    |
      | old         | 1             | file.txt    | file.txt    |
      | old         | texta         | 0           | file.txt    |
      | old         | texta         | 1           | file.txt    |
      | old         | texta         | file.txt    | 0           |
      | old         | texta         | file.txt    | 1           |
        HTTP status code 500 is not the expected value 201
        Failed asserting that 500 matches expected '201'.
      | new         | 0             | file.txt    | file.txt    |
      | new         | 1             | file.txt    | file.txt    |
      | new         | texta         | 0           | file.txt    |
      | new         | texta         | 1           | file.txt    |
      | new         | texta         | file.txt    | 0           |
      | new         | texta         | file.txt    | 1           |

--- Failed scenarios:

    /home/phil/git/owncloud/core/tests/acceptance/features/apiWebdavMove2/moveFile.feature:453

12 scenarios (11 passed, 1 failed)
108 steps (105 passed, 1 failed, 2 skipped)
1m51.32s (18.36Mb)

The fails happened when the target of the move was a path that starts with a non-zero number
For example, moving a file up to the root and calling it "1".
Or moving a file to a folder called "1".

Somehow the cases where the target path starts with a "0" did not fail.

CI passes with the 2nd commit, and 3rd commit.

Also, everything was OK with the "new" dav_version. Only "old" dav_version failed. That seems strange, but I guess there must be different ways that those make use of sabre/dav

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[individual-it]

this issue was first discovered using the windows explorer and I it only happened when moving a numeric file/folder to the root of the tree
so you maybe want to add those tests also

[phil-davis]

this issue was first discovered using the windows explorer and I it only happened when moving a numeric file/folder to the root of the tree so you maybe want to add those tests also

done in 3rd commit

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information