Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Add spaces tests on apiAuthWebDav suites #39718

Merged
merged 1 commit into from
Jan 26, 2022
Merged

[tests-only][full-ci]Add spaces tests on apiAuthWebDav suites #39718

merged 1 commit into from
Jan 26, 2022

Conversation

amrita-shrestha
Copy link
Contributor

@amrita-shrestha amrita-shrestha commented Jan 25, 2022 •
edited
Loading

Description

use spaces DAV path in apiAuthWebDav suite

Related Issue

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@amrita-shrestha amrita-shrestha self-assigned this Jan 25, 2022
@amrita-shrestha amrita-shrestha mentioned this pull request Jan 25, 2022
Merged
5 tasks
@sonarcloud
Copy link

sonarcloud bot commented Jan 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

kiranparajuli589
kiranparajuli589 previously requested changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, spaces DAV path does not contain remote.php. please change the URLs for every use case.

tests/acceptance/features/apiAuthWebDav/webDavDELETEAuth.feature Show resolved Hide resolved
kiranparajuli589
kiranparajuli589 reviewed Jan 25, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@amrita-shrestha amrita-shrestha marked this pull request as ready for review January 25, 2022 11:24
@phil-davis
Copy link
Contributor

@kiranparajuli589 please give a "full green" review, or dismiss your previous red review.

@kiranparajuli589 kiranparajuli589 dismissed their stale review January 25, 2022 11:27

sorry remote.php optional was optional, that commet is not true

@phil-davis phil-davis merged commit 65a12d1 into master Jan 26, 2022
@delete-merged-branch delete-merged-branch bot deleted the apiAuthWebDav branch January 26, 2022 05:26
@phil-davis phil-davis mentioned this pull request Jan 26, 2022
Closed
9 tasks
This was referenced Jan 26, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiranparajuli589 kiranparajuli589 kiranparajuli589 approved these changes

@phil-davis phil-davis phil-davis approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

Assignees

@amrita-shrestha amrita-shrestha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add spaces webdav for apiAuthWebDav suite
3 participants
@amrita-shrestha @phil-davis @kiranparajuli589