Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] Add tests for moving a share inside another share #39724

Merged
merged 1 commit into from
Jan 27, 2022
Merged

[tests-only] Add tests for moving a share inside another share #39724

merged 1 commit into from
Jan 27, 2022

Conversation

phil-davis
Copy link
Contributor

Description

This PR adds some test scenarios for moving existing shares inside each other. It demonstrates some combinations related/similar to the problem described in the issue.

Related Issue

#39000

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis self-assigned this Jan 27, 2022
@phil-davis phil-davis mentioned this pull request Jan 27, 2022
Open
@sonarcloud
Copy link

sonarcloud bot commented Jan 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit e20f325 into master Jan 27, 2022
@delete-merged-branch delete-merged-branch bot deleted the tests-issue-39000 branch January 27, 2022 15:29
@phil-davis phil-davis mentioned this pull request Jan 28, 2022
Closed
@amrita-shrestha amrita-shrestha mentioned this pull request Jan 28, 2022
Merged
5 tasks
@phil-davis phil-davis mentioned this pull request Jan 28, 2022
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@individual-it individual-it individual-it approved these changes

@jnweiger jnweiger Awaiting requested review from jnweiger

Assignees

@phil-davis phil-davis

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phil-davis @individual-it