Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] [full-ci] Added spaces for suite apiWebdavOperations #39729

Merged
merged 1 commit into from
Feb 7, 2022
Merged

[tests-only] [full-ci] Added spaces for suite apiWebdavOperations #39729

merged 1 commit into from
Feb 7, 2022

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Jan 28, 2022 •
edited by amrita-shrestha
Loading

Description

Added Spaces for suite apiWebdavOperations

Related Issue

Motivation and Context

How Has This Been Tested?

  • CI
  • Locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@CLAassistant
Copy link

CLAassistant commented Jan 28, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUIUpload-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34452/151/1

@amrita-shrestha amrita-shrestha changed the title [test-only] Added spaces examples for suite apiWebdavOperations [test-only] Added spaces for suite apiWebdavOperations Jan 31, 2022
@amrita-shrestha amrita-shrestha changed the title [test-only] Added spaces for suite apiWebdavOperations [tests-only] Added spaces for suite apiWebdavOperations Jan 31, 2022
@SagarGi SagarGi force-pushed the apiWebdavOperations branch from bac62ec to b9bffd6 Compare January 31, 2022 04:02
@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiWebdavOperations-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34456/94/1

@owncloud owncloud deleted a comment from update-docs bot Jan 31, 2022
@amrita-shrestha amrita-shrestha changed the title [tests-only] Added spaces for suite apiWebdavOperations [tests-only] [full-ci] Added spaces for suite apiWebdavOperations Jan 31, 2022
@amrita-shrestha amrita-shrestha marked this pull request as draft January 31, 2022 08:22
@SagarGi SagarGi force-pushed the apiWebdavOperations branch 3 times, most recently from 6352719 to b97fa49 Compare February 3, 2022 04:13
@amrita-shrestha amrita-shrestha self-requested a review February 3, 2022 04:49
@kiranparajuli589
Copy link
Contributor

sorry the ci build failed at install-core in several suites, build restarted

@kiranparajuli589 kiranparajuli589 self-requested a review February 3, 2022 08:51
@SagarGi SagarGi force-pushed the apiWebdavOperations branch from 50d7b3e to 0d871e0 Compare February 3, 2022 10:57
@SagarGi SagarGi force-pushed the apiWebdavOperations branch from 0d871e0 to 36c4dcb Compare February 4, 2022 07:56
kiranparajuli589
kiranparajuli589 reviewed Feb 4, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@SagarGi SagarGi marked this pull request as ready for review February 4, 2022 08:06
@kiranparajuli589 kiranparajuli589 dismissed their stale review February 4, 2022 08:06

requested changes had been made

@kiranparajuli589 kiranparajuli589 mentioned this pull request Feb 4, 2022
Merged
11 tasks
@amrita-shrestha amrita-shrestha mentioned this pull request Feb 7, 2022
Closed
@SagarGi SagarGi force-pushed the apiWebdavOperations branch from 36c4dcb to f01eb79 Compare February 7, 2022 04:56
@phil-davis
Copy link
Contributor

Issue #39549 webUIUpload/upload.feature:131 failed. Unrelated to this PR. I restarted CI.

@phil-davis
Copy link
Contributor

@SagarGi I just merged PR #39745 that @amrita-shrestha made last week. It had similar changes to tests/acceptance/features/bootstrap/WebDav.php getFullDavFilesPath but not quite the same.

Please rebase this PR and sort out if there are any more changes needed to getFullDavFilesPath, or if her changes are OK.

@SagarGi SagarGi force-pushed the apiWebdavOperations branch from f01eb79 to 2cbd88d Compare February 7, 2022 08:41
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@phil-davis phil-davis merged commit a0fb3af into owncloud:master Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrita-shrestha amrita-shrestha amrita-shrestha left review comments

@saw-jan saw-jan saw-jan left review comments

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@phil-davis phil-davis phil-davis approved these changes

Assignees

@SagarGi SagarGi

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@SagarGi @CLAassistant @ownclouders @kiranparajuli589 @phil-davis @saw-jan @amrita-shrestha