Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] added spaces examples in the api WebDAV locks suite #39749

Merged
merged 1 commit into from
Feb 7, 2022
Merged

[tests-only] added spaces examples in the api WebDAV locks suite #39749

merged 1 commit into from
Feb 7, 2022

Conversation

kiranparajuli589
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 commented Feb 3, 2022 •
edited
Loading

Description

Added spaces examples in the suite apiWebdavLocks

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiAuth-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34510/47/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiAuthWebDav-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34510/49/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiMain-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34510/53/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiShareCreateSpecialToRoot1-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34510/58/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiFavorites-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34510/52/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiCapabilities-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34510/50/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiWebdavLocks2-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34510/89/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiWebdavLocks3-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34510/90/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiWebdavPreviews-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34510/95/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline cliExternalStorage-git-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34510/122/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiFederationToShares2-latest-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34510/112/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiFederationToShares1-git-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34510/108/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiFederationToRoot2-10.8.0-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34510/107/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline cliMain-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34510/116/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUIAddUsers-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34510/125/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUIUpload-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34511/151/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUIUpload-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34517/151/1

@kiranparajuli589
Copy link
Contributor Author

kiranparajuli589 commented Feb 4, 2022 •
edited
Loading

webUIUpload/upload.feature:131 failed

@webUI @insulated @disablePreviews @files_sharing-app-required
Feature: File Upload
  
  As a user
  I would like to be able to upload files via the WebUI
  So that I can store files in ownCloud

  Background:                                                                              # /drone/src/tests/acceptance/features/webUIUpload/upload.feature:8
    Given user "Alice" has been created with default attributes and without skeleton files # FeatureContext::userHasBeenCreatedWithDefaultAttributesAndWithoutSkeletonFiles()

  @files_sharing-app-required
  Scenario: upload overwriting a file into a public share                                               # /drone/src/tests/acceptance/features/webUIUpload/upload.feature:131
    Given user "Alice" has created folder "/simple-folder"                                              # FeatureContext::userHasCreatedFolder()
    And user "Alice" has uploaded file "filesForUpload/lorem.txt" to "/simple-folder/lorem.txt"         # FeatureContext::userHasUploadedAFileTo()
    And user "Alice" has created a public link share with settings                                      # FeatureContext::userHasCreatedAPublicLinkShareWithSettings()
      | path        | /simple-folder     |
      | permissions | read,update,create |
    When the public accesses the last created public link using the webUI                               # WebUISharingContext::thePublicAccessesTheLastCreatedPublicLinkUsingTheWebUI()
INFORMATION: timed out waiting for ajax calls to start
Upload overwriting lorem.txt and got 1 notifications including You don’t have permission to upload or create files here

INFORMATION: timed out waiting for ajax calls to start
    And the user uploads overwriting file "lorem.txt" using the webUI and retries if the file is locked # WebUIFilesContext::theUserUploadsOverwritingFileUsingTheWebUIRetry()
      │ INFORMATION: timed out waiting for ajax calls to startUpload overwriting lorem.txt and got 1 notifications including You don’t have permission to upload or create files here
      │ INFORMATION: timed out waiting for ajax calls to start
      WebUIFilesContext::choiceInUploadConflictDialogWebUI file upload conflict dialog expected but not found (Exception)
    Then file "lorem.txt" should be listed on the webUI                                                 # WebUIFilesContext::fileFolderShouldBeListedOnTheWebUI()
    When user "Alice" logs in using the webUI                                                           # WebUILoginContext::logInWithUsernameUsingTheWebUI()
    And the content of "simple-folder/lorem.txt" should be the same as the local "lorem.txt"            # WebUIFilesContext::theContentOfShouldBeTheSameAsTheLocal()
SCENARIO RESULT: (fail)

@kiranparajuli589 kiranparajuli589 self-assigned this Feb 4, 2022
This was referenced Feb 4, 2022
Merged
Closed
@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiWebdavLocks-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34521/88/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUIUpload-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34523/151/1

amrita-shrestha
amrita-shrestha reviewed Feb 4, 2022
View reviewed changes
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUIUpload-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34534/151/1

@phil-davis
Copy link
Contributor

I rebased to get up-to-date CI. This can be merged when CI is green

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit a11417c into master Feb 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the spaces-webdav-locks branch February 7, 2022 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrita-shrestha amrita-shrestha amrita-shrestha left review comments

@phil-davis phil-davis phil-davis approved these changes

Assignees

@kiranparajuli589 kiranparajuli589

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kiranparajuli589 @ownclouders @phil-davis @amrita-shrestha