Add product to version in capabilities response

[kulmann]

Description

Add product to version in capabilities response

This has been introduced by oCIS recently to announce oCIS with a proper
product name. The web ui (as just another API client) defaults to
"ownCloud" if the property is not set. With this enhancement we show the
product name for ownCloud Server as well so that clients don't have to
guess a sane default.

Motivation and Context

Handle all clients equally.

How Has This Been Tested?

... manually with a capabilities request 👀

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[phil-davis]

capabilites/core/status and status.php already contain a data item called productname.

Should we add a data item called product to those, just to be consistent?
The value would be reported the same as for productname.

Then clients can find this called product everywhere, and productname could be "deprecated" (but we would never need to remove it).

PR #39857 is my example.

[phil-davis]

Note: it would be good to have a test somewhere for the version data items. I will have a look tomorrow - if there is no API test scenario then I will add one, because we want to automagically have a test that runs on both oC10 and oCIS-reva that confirms that the data items exist and have some "reasonable" values.

[kulmann]

Then clients can find this called product everywhere, and productname could be "deprecated" (but we would never need to remove it).

I do like that! Added a commit to this PR. Let's see if someone disagrees. 😁

[phil-davis]

I added the test code. Hopefully it passes. I will enhance the test for the "version" data items so that it also checks the major/minor/micro values for reasonableness.

[phil-davis]

I added the test code. Hopefully it passes. I will enhance the test for the "version" data items so that it also checks the major/minor/micro values for reasonableness.

Test has been enhanced so it validates the major-minor-micro values. A capabilities response has a version section like:

  <version>
   <major>10</major>
   <minor>9</minor>
   <micro>2</micro>
   <string>10.9.2 prealpha</string>
   <edition>Enterprise</edition>
   <product>ownCloud</product>
  </version>

The test finds the string with "10.9.2" at the start and checks that the major, minor and micro data items have the matching values.

[ownclouders]

💥 Acceptance tests pipeline apiAuth-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34842/47/1

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

33.3% Coverage
0.0% Duplication

[phil-davis]

@micbar IMO this is ready to merge. Are you (or anyone) OK with this capabilities enhancement?

[jnweiger]

Confirmed fixed in 10.10.0 rc2

<version>
<major>10</major>
<minor>10</minor>
<micro>0</micro>
<string>10.10.0 rc2</string>
<edition>Enterprise</edition>
<product>ownCloud</product>
</version>

The 'edition' normally is 'Community' -- it changes to 'Enterprise', as soon as a license is added.